[gym] Enable multi-GPU support with PPO when mirror_mat are defined #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You broke something else by trying to fix your bug. I suggest to keep the output of train as it is currently, but fix typing and doc, then adapt the other parts that assumes it returns the checkpoint path. |
mwulfman
changed the title
duburcqa
reviewed
Apr 27, 2024
mwulfman
force-pushed
the
fix-rllib-utilities
branch
from
a9ac060 to
3cdc6a6
Compare
mwulfman
changed the title
Merged
duburcqa
added a commit
that referenced
this pull request
Apr 28, 2024
* [core] Full support of serialization of 'Robot'. (#770) (#775) * [core] Do NOT use 'enable_shared_from_this' if not strictly necessary. (#775) * [core] Rename macro 'PRINT_WARNING' in 'JIMINY_WARNING' to avoid conflicts. (#775) * [python/simulator] 'plot' now support multi-robot simulations. (#770) * [gym/common] Speedup 'PDController' env pipeline block. (#770) * [gym/common] Speedup 'StackedJiminyEnv' wrapper. (#770) * [gym/common] More generic 'FilterObservation', 'StackedJiminyEnv' wrappers. (#770) (#776) * [gym/common] Improve 'render_mode' support. * [gym/zoo] Cleanup and speedup toy model environments. (#770) * [gym/rllib] Fix multi-GPU support using custom PPO (#774) * [gym/rllib] Fix 'train' method typing and documentation. (#775) * [misc] Fix partially broken 'mypy' static type checking for 'jiminy_py' module. (#770) * [misc] Add RL tutorial notebook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #773