Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pangraphs is not taking care of inversions #6

Closed
dubssieg opened this issue Oct 4, 2023 · 4 comments
Closed

pangraphs is not taking care of inversions #6

dubssieg opened this issue Oct 4, 2023 · 4 comments
Assignees
@dubssieg
Labels
bug Something isn't working testing In-depth tests are required

Comments

@dubssieg
Copy link
Owner

dubssieg commented Oct 4, 2023

The commands reconstruct and edit are not aware of inversions. It will yield incorrect sequences, or refuse to do comparison because this is not correctly implemented.
@dubssieg dubssieg added the bug Something isn't working label Oct 4, 2023
@dubssieg dubssieg self-assigned this Oct 4, 2023
dubssieg added a commit that referenced this issue Oct 4, 2023
@dubssieg
Fix of #6 for reconstruct
b782347
@dubssieg
Copy link
Owner Author

dubssieg commented Oct 4, 2023

reconstruct is fixed, with upgrades on it's internals. Now it correctly uses the lib.

dubssieg added a commit that referenced this issue Oct 4, 2023
@dubssieg
Fix of #6 for edit
77911d8
@dubssieg
Copy link
Owner Author

dubssieg commented Oct 4, 2023

fix has been deployed for edit, needs testing before closing as solved

@dubssieg dubssieg added the testing In-depth tests are required label Oct 6, 2023
@dubssieg
Copy link
Owner Author

fix is tested for reconstruct and works in 3339054

@dubssieg
Copy link
Owner Author

After extensive testing, we can see this issue as solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dubssieg dubssieg

Labels
bug Something isn't working testing In-depth tests are required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dubssieg