Fix #2, view parent is unnecessary

duanhong169 · Sep 7, 2018 · 31604fb · 31604fb
1 parent a2cd044
commit 31604fb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/app/src/main/java/top/defaults/colorpickerapp/MainActivity.java b/app/src/main/java/top/defaults/colorpickerapp/MainActivity.java
@@ -38,7 +38,7 @@ void popup(View v) {
                 .showIndicator(true)
                 .showValue(true)
                 .build()
-                .show(v, new ColorPickerPopup.ColorPickerObserver() {
+                .show(new ColorPickerPopup.ColorPickerObserver() {
                     @Override
                     public void onColorPicked(int color) {
                         v.setBackgroundColor(color);

diff --git a/colorpicker/src/main/java/top/defaults/colorpicker/ColorPickerPopup.java b/colorpicker/src/main/java/top/defaults/colorpicker/ColorPickerPopup.java
@@ -36,6 +36,10 @@ private ColorPickerPopup(Builder builder) {
         this.showValue = builder.showValue;
     }
 
+    public void show(final ColorPickerObserver observer) {
+        show(null, observer);
+    }
+
     public void show(View parent, final ColorPickerObserver observer) {
         LayoutInflater inflater = (LayoutInflater) context.getSystemService(LAYOUT_INFLATER_SERVICE);
         if (inflater == null) return;
@@ -93,6 +97,7 @@ public void onColor(int color, boolean fromUser) {
         }
 
         popupWindow.setAnimationStyle(R.style.TopDefaultsViewColorPickerPopupAnimation);
+        if (parent == null) parent = layout;
         popupWindow.showAtLocation(parent, Gravity.CENTER, 0, 0);
     }