Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open mailComposeController Method to Modification #43

Merged
merged 1 commit into from
May 29, 2019

Conversation

GeorgeRoyce
Copy link
Collaborator

What does this PR do?

Allows other UIViewController subclasses to implement mailComposeController(_ didFinishWithResult)

Any context you'd like to provide?

This came about while attempting to integrate BugShaker into a project that already conformed to the MFMailComposeViewControllerDelegate. If another/better way to work around this comes about I'm happy to revisit!

@codecov-io
Copy link

Codecov Report

Merging #43 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #43   +/-   ##
========================================
  Coverage    98.63%   98.63%           
========================================
  Files            3        3           
  Lines          146      146           
========================================
  Hits           144      144           
  Misses           2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 193cf30...76e50a8. Read the comment docs.

Copy link
Owner

@dtrenz dtrenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice!

@dtrenz dtrenz merged commit 92cd108 into develop May 29, 2019
@dtrenz dtrenz deleted the mailComposeController-overrides branch May 29, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants