Hide line numbers in $WORKSPACE errors #85
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83.
Before:
After:
I think compiletest-rs does this by subbing all line numbers with
:LL:COL
(https://github.com/rust-lang/rust/blob/18f3be7704a4ec7976fcd1272c728974243d29bd/src/test/ui/consts/offset_ub.stderr). I am not a fan of that since I find it breaks the immersion and makes it harder for a human reader to visually perceive the file as a user-facing compiler diagnostic that's worth critically evaluating and improving, as opposed to a test.