Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New "full type name" files are not normalized #212

Closed
MingweiSamuel0 opened this issue Dec 15, 2022 · 2 comments · Fixed by #213
Closed

New "full type name" files are not normalized #212

MingweiSamuel0 opened this issue Dec 15, 2022 · 2 comments · Fixed by #213

Comments

@MingweiSamuel0
Copy link

MingweiSamuel0 commented Dec 15, 2022 •
edited
Loading

rustc 1.68.0-nightly (0f529f0f4 2022-12-13)

Latest nightlies output large types in their own file with a randomized name:

  = note: the full type name has been written to '$WORKSPACE/target/tests/target/x86_64-pc-windows-msvc/debug/deps/$CRATE-91b1ba6fa3ca7460.long-type-8728300020286882769.txt'

Looks like both the numeric part of the filename also the target x86_64-pc-windows-msvc need to be normalized
@MingweiSamuel0
Copy link
Author

Might be a rustc bug looking at this

@MingweiSamuel0
Copy link
Author

Also seems to be emitting a different path for $RUST on ubuntu

note: required by a bound in `std::iter::Iterator::chain`
 --> /rustc/b70baa4f922a1809d79caeaeb902800c3be283b9/library/core/src/iter/traits/iterator.rs:499:5

which doesn't match /rustlib/src/rust/src/ or /rustlib/src/rust/library/ which is what trybuild is normalizing

This was referenced Jan 4, 2023
Merged
Merged
JohnTitor pushed a commit to JohnTitor/rust that referenced this issue Jan 9, 2023
Rollup merge of rust-lang#106468 - compiler-errors:err-instability, r…
72cddd6 
…=lcnr

Use FxIndexSet when updating obligation causes in `adjust_fulfillment_errors_for_expr_obligation`

I have no idea how to test this reliably, but I've **manually** verified it fixes the instability in rust-lang#106417 that isn't due to dtolnay/trybuild#212.

Fixes rust-lang#106417
JohnTitor pushed a commit to JohnTitor/rust that referenced this issue Jan 9, 2023
Rollup merge of rust-lang#106468 - compiler-errors:err-instability, r…
d3cae2b 
…=lcnr

Use FxIndexSet when updating obligation causes in `adjust_fulfillment_errors_for_expr_obligation`

I have no idea how to test this reliably, but I've **manually** verified it fixes the instability in rust-lang#106417 that isn't due to dtolnay/trybuild#212.

Fixes rust-lang#106417
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this issue Jan 9, 2023
@fee1-dead
Rollup merge of rust-lang#106468 - compiler-errors:err-instability, r…
357128a 
…=lcnr

Use FxIndexSet when updating obligation causes in `adjust_fulfillment_errors_for_expr_obligation`

I have no idea how to test this reliably, but I've **manually** verified it fixes the instability in rust-lang#106417 that isn't due to dtolnay/trybuild#212.

Fixes rust-lang#106417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete 'full type name' notes compiler-errors/trybuild
1 participant
@MingweiSamuel0