Change span of as_dyn_error()
to point compile error at attribute.
#258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the span of the
as_dyn_error()
call to the#[source]
,#[from]
or#[transparant]
attribute if it exists.My motivation was a (to me) confusing error that actually made me think
thiserror
had a bug:The error uses the span of the source member, but in this case it is unnamed. How exactly it ends up with the span of the string literal is a bit unclear to me. Maybe because the member (
0
) is used in the formatting code?Regardless, with this PR, the error is the same but the span is changed to the attribute:
If there was no
#[source]
,#[from]
or#[transparent]
attribute, the member name is used as before (which in practise means it must be a member namedsource
).