Add VariantData#fields_mut
#26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the mutable equivalent to `VariantData#fields`, and can make code which needs to mutate those fields a bit less verbose.
sgrif
commented
Oct 3, 2016
| match *self { | ||
| VariantData::Struct(ref mut fields) | | ||
| VariantData::Tuple(ref mut fields) => fields, | ||
| VariantData::Unit => &mut [], |
There was a problem hiding this comment.
I was shocked that this worked. I get that it's completely valid from a memory safety point of view since there's no operation that could actually mutate an empty slice, but I didn't think the compiler would special case empty slices vs non-empty here.
|
There are some breaking changes sitting in master so I cherry-picked this across to the 0.8 branch as 15085c4 and released it in 0.8.6. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the mutable equivalent to
VariantData#fields, and can makecode which needs to mutate those fields a bit less verbose.