Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse default values in fields #1774

Open
dtolnay opened this issue Oct 29, 2024 · 0 comments
Open

Parse default values in fields #1774

dtolnay opened this issue Oct 29, 2024 · 0 comments
Labels
syntax

Comments

@dtolnay
Copy link
Owner

dtolnay commented Oct 29, 2024 •
edited
Loading 

#[derive(Default)]
struct Pet {
    name: Option<String>,
    age: i128 = 42,
    //        ^^^^
}
@dtolnay dtolnay added the syntax label Oct 29, 2024
@sbant sbant mentioned this issue Jan 14, 2025
Closed
@estebank estebank mentioned this issue Mar 6, 2025
Closed
estebank added a commit to estebank/syn that referenced this issue Mar 6, 2025
@estebank
Support parsing #![feature(default_field_values)]
3939194 
- RFC: rust-lang/rfcs#3681
- Tracking issue: rust-lang/rust#132162
- Feature gate: `#![feature(default_field_values)]`

```rust
struct Pet {
    name: Option<String>,
    age: i128 = 42,
    //        ^^^^
}
```

Fix dtolnay#1774.
estebank added a commit to estebank/syn that referenced this issue Mar 6, 2025
@estebank
Support parsing #![feature(default_field_values)]
6671f48 
- RFC: rust-lang/rfcs#3681
- Tracking issue: rust-lang/rust#132162
- Feature gate: `#![feature(default_field_values)]`

```rust
struct Pet {
    name: Option<String>,
    age: i128 = 42,
    //        ^^^^
}
```

Fix dtolnay#1774.
estebank added a commit to estebank/syn that referenced this issue Mar 6, 2025
@estebank
Support parsing #![feature(default_field_values)]
8303beb 
- RFC: rust-lang/rfcs#3681
- Tracking issue: rust-lang/rust#132162
- Feature gate: `#![feature(default_field_values)]`

```rust
struct Pet {
    name: Option<String>,
    age: i128 = 42,
    //        ^^^^
}
```

Fix dtolnay#1774.
@estebank estebank mentioned this issue Mar 6, 2025
Merged
jhpratt added a commit to jhpratt/rust that referenced this issue Mar 7, 2025
@jhpratt
Rollup merge of rust-lang#138111 - estebank:use-dfv, r=nnethercote
8dddb3f 
Use `default_field_values` for `rustc_errors::Context`, `rustc_session::config::NextSolverConfig` and `rustc_session::config::ErrorOutputType`

Wanted to see  where `#![feature(default_field_values)]` could be used in the codebase. These three seemed like no-brainers. There are a bunch of more places where we could remove manual `Default` impls, but they `derive` other traits that rely on `syn`, which [doesn't yet support `default_field_values`](dtolnay/syn#1774).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 7, 2025
@matthiaskrgr
Rollup merge of rust-lang#138111 - estebank:use-dfv, r=nnethercote
774976a 
Use `default_field_values` for `rustc_errors::Context`, `rustc_session::config::NextSolverConfig` and `rustc_session::config::ErrorOutputType`

Wanted to see  where `#![feature(default_field_values)]` could be used in the codebase. These three seemed like no-brainers. There are a bunch of more places where we could remove manual `Default` impls, but they `derive` other traits that rely on `syn`, which [doesn't yet support `default_field_values`](dtolnay/syn#1774).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 7, 2025
@matthiaskrgr
Rollup merge of rust-lang#138111 - estebank:use-dfv, r=nnethercote
acc7de6 
Use `default_field_values` for `rustc_errors::Context`, `rustc_session::config::NextSolverConfig` and `rustc_session::config::ErrorOutputType`

Wanted to see  where `#![feature(default_field_values)]` could be used in the codebase. These three seemed like no-brainers. There are a bunch of more places where we could remove manual `Default` impls, but they `derive` other traits that rely on `syn`, which [doesn't yet support `default_field_values`](dtolnay/syn#1774).
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 7, 2025
@rust-timer
Unrolled build for rust-lang#138111
6c56e53 
Rollup merge of rust-lang#138111 - estebank:use-dfv, r=nnethercote

Use `default_field_values` for `rustc_errors::Context`, `rustc_session::config::NextSolverConfig` and `rustc_session::config::ErrorOutputType`

Wanted to see  where `#![feature(default_field_values)]` could be used in the codebase. These three seemed like no-brainers. There are a bunch of more places where we could remove manual `Default` impls, but they `derive` other traits that rely on `syn`, which [doesn't yet support `default_field_values`](dtolnay/syn#1774).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
syntax
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support parsing #![feature(default_field_values)] estebank/syn
1 participant
@dtolnay