Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RangeLimits does not implement ToTokens #1157

Closed
frank2 opened this issue Apr 5, 2022 · 1 comment
Closed

RangeLimits does not implement ToTokens #1157

frank2 opened this issue Apr 5, 2022 · 1 comment

Comments

@frank2
Copy link
Contributor

frank2 commented Apr 5, 2022

Hello! This is a very simple issue I noticed. The RangeLimits enum doesn't implement ToTokens, which is out of step with the rest of the enums in the library. I'm assuming this is an oversight and not intentional since so many other enums implement ToTokens.

Since this is such a simple fix I'll follow up with a PR to fix the issue!
frank2 added a commit to frank2/syn that referenced this issue Apr 5, 2022
@frank2
dtolnay#1157 implement ToTokens for RangeLimits enum
72e6ffc
dtolnay added a commit that referenced this issue Apr 5, 2022
@dtolnay
Merge pull request #1158 from frank2/rangelimits-to-tokens
d94e7f1 
#1157 implement ToTokens for RangeLimits enum
@frank2
Copy link
Contributor Author

frank2 commented Apr 11, 2022

This is merged, so I'm gonna close it!

@frank2 frank2 closed this as completed Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@frank2