Mark Ident::new_raw as no longer semver-exempt #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous Compiler behaviour appears to have been broken, in that it would return a non-raw string literal, so it was replaced with the fallback code from quote [1]. [1]: https://github.com/dtolnay/quote/blob/eeabf0d42ed68418741542ab5cfa8a9d339f8a79/src/runtime.rs#L409-L422
|
I found another issue in that the fallback implementation doesn't appear to be performing raw identifier validation correctly. I've added some logic modeled after https://github.com/rust-lang/rust/blob/bb8c2f41174caceec00c28bc6c5c20ae9f9a175c/compiler/rustc_span/src/symbol.rs#L1973-L1991 to account for that, and some basic tests for it. |
mystor
added a commit
to mystor/quote
that referenced
this pull request
Jun 20, 2022
This requires the changes in dtolnay/proc-macro2#331 which expose Ident::new_raw from proc-macro2, along with providing a fallback for earlier versions of Rust. Fixes dtolnay#223
dtolnay
pushed a commit
to mystor/quote
that referenced
this pull request
Jun 20, 2022
This requires the changes in dtolnay/proc-macro2#331 which expose Ident::new_raw from proc-macro2, along with providing a fallback for earlier versions of Rust. Fixes dtolnay#223
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous Compiler behaviour appears to have been broken, in that it
would return a non-raw string literal, so it was replaced with the
fallback code from quote.
This will be needed to fix dtolnay/quote#223