Feature 642 test ci updates #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nter/METplus into feature_642_distance_map_tb
… exist yet for new use case
…nges from #768 available to be able to do the same for MODE config, but I added the overrides that will be needed when that is available
…leaned up conf file
…ilter cases based on the index value instead of the index of the list
…ce large output artifacts, split up grouped use case categories for simplicity, added explicit indices of cases for all groups so the names of the GHA jobs/artifacts and Docker data volumes are more descriptive and new cases can be added separately to isolate differences caused by new data from a new use case
21 tasks
JohnHalleyGotway
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
I looked through these changes and understand that we’re updating the test definition to include an integer index and enabling the actions to reference those indices. As George notes, the GHA tests succeeded for the push but failed in the PR which diffs against the existing output since the output has been reorganized. The changes include good updates to the docs. I just read the .rst files and am eager to be able to review docs changes via RTD.
Thanks for working through these details George.
I approve of these changes.
georgemccabe
added a commit
that referenced
this pull request
Mar 15, 2021
Co-authored-by: Christina Kalb <kalb@kiowa.rap.ucar.edu> Co-authored-by: George McCabe <mccabe@ucar.edu> Co-authored-by: bikegeek <minnawin@ucar.edu> Co-authored-by: bikegeek <3753118+bikegeek@users.noreply.github.com> Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: CPKalb <kalb@ucar.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rearranged the use case groups so that there are no jobs create very large output artifacts. I changed the format of the names to include the full range of use case indices in a group. I updated the documentation to reflect these changes and instruct users to put new use cases in a separate group to make it easier to review that any differences are from the addition of the new use case.
I created issue #839 because I noticed at least 1 use case takes an incredibly long time to obtain a python package and only a few seconds to run the actual use case.
Pull Request Testing
Verified that GitHub Actions runs successfully.
Review the pull request run in GitHub Actions and ensure everything looks correct. Note that the diffs will fail because the use case groups were rearranged, but we have already confirmed the data is correct from PR #825.
Do these changes include sufficient documentation and testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes or No]
Different grouping of outputs will require an update to the develop-ref branch to re-create the truth data volumes.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s), Project(s), and Milestone