Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 413 surrogate severe calculation round 2 #450

Merged
merged 29 commits into from
May 15, 2020

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Apr 29, 2020

I found a few things that need to be fixed in these files before we can merge it into develop. I starting making some of the changes on the feature branch, but I don't have time to fix the rest. The rest of the changes can be done on the same feature branch.

  1. GridSta_fcstHRRR_obsPP_SurrogateSevereProb.conf - typo - should be GridStat (DONE)

  2. PcpComb_EnsStat_Regrid_fcstHRRR_fcstonly_SurrogateSevere.conf - the name should contain the full name of the evaluation tool(s), so just EnsembleStat. also should be fcstOnly instead of fcstonly (DONE)

  3. PARM_BASE shouldn't be set in the config files - it is set automatically by METplus and it will error out if it is set to a value that differs from the generated path.

  4. GRID_STAT_OUTPUT_DIR is set relative to the INPUT_BASE. It should be relative to OUTPUT_BASE to separate out inputs from outputs (done in one file, there may be others)

  5. The PcpComb_.. example (now EnsembleStat_fcstHRRR_fcstOnly_SurrogateSevere.conf) contains INPUT_BASE, OUTPUT_BASE, and PARM_BASE. None of these should be in these files. The user will set INPUT_BASE and OUTPUT_BASE in their user config file.

  6. Write .py documentation files for each use case (these should now go in METplus/docs/use_cases/model_applications/convection_allowing_models)

  7. Put the input data on kiowa in the appropriate input data directory (under /d1/projects/METplus/METplus_Data following the use_cases dir structure)

  8. Someone other than the author should test running the use cases to make sure they can be run by any user

Lindsay Blank and others added 13 commits April 15, 2020 19:52
…DataPlane) completed. Adding a second .conf file in order to not mess up anyone working off of 'surrogate_severe_Ens_fcstHRRR.conf
…rogate severe calculation. This commit removes the need for surrogate_severe_Ens_fcstHRRR_lrb.conf
…fcstHRRR_lrb.conf into one .conf file that runs all 4 surrogate severe steps completely.
…pComb_EnsStat_Regrid_fcstHRRR_fcstonly_SurrogateSevere.conf
Copy link

@lindsayrblank lindsayrblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see below comments.

Copy link

@lindsayrblank lindsayrblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made changes to the .conf file to fix issue 5. Issues 5 and 7 are fixed. I'm working on issue 6. Someone other than me should now test the changes I made.

@lindsayrblank
Copy link

I just committed the documentation (issue 6).

@CPKalb
Copy link
Contributor

CPKalb commented May 15, 2020

It worked for me on Kiowa

@CPKalb CPKalb closed this May 15, 2020
@CPKalb CPKalb reopened this May 15, 2020
@georgemccabe
Copy link
Collaborator Author

I just moved the use case documentation file to the docs directory so it will show up on Sphinx. I pushed the change to the feature branch which kicked off the pull request test on Travis again. This change can't affect the tests, so I think it is OK to merge this PR if you are all satisfied with the changes.

We will need to add this use case to the test_use_cases.py script under convection_allowing_models, but it will fail on Travis because the input files are not available there yet.

@georgemccabe georgemccabe merged commit ab41e29 into develop May 15, 2020
@georgemccabe georgemccabe deleted the feature_413_surrogate_severe_calculation branch May 15, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants