Code

Bugfix diff tests#2217

Code

Merged

georgemccabe merged 19 commits intodevelopdtcenter/METplus:developfrom bugfix_gha_diffdtcenter/METplus:bugfix_gha_diffCopy head branch name to clipboardJun 16, 2023

+303-163

Commits

Commits on Jun 14, 2023

• update diff util and test that changes properly diff failling diffs, ci-run-diff

  georgemccabe

  committed
  2c0332a

  Copy full SHA for 2c0332a

• turn off use case

  georgemccabe

  committed
  905b409

  Copy full SHA for 905b409

• catch any exception that occurs in NetCDF file diff, ci-skip-unit-tests

  georgemccabe

  committed
  c2b6e3a

  Copy full SHA for c2b6e3a

• catch any exception from file diff instead of just in NetCDF diff, ci-skip-unit-tests

  georgemccabe

  committed
  5fdee80

  Copy full SHA for 5fdee80

• forgot to trigger diff, ci-run-diff, ci-skip-unit-tests

  georgemccabe

  committed
  21af4b2

  Copy full SHA for 21af4b2

• use pandas.isnull instead of numpy.isnan to prevent exceptions from occurring, ci-run-diff, ci-skip-unit-tests

  georgemccabe

  committed
  2172134

  Copy full SHA for 2172134

• capture failure in diff script, ci-run-diff, ci-skip-unit-tests

  georgemccabe

  committed
  eefaa0c

  Copy full SHA for eefaa0c

• ignore .idea directory that was auto-generated

  georgemccabe

  committed
  0201daa

  Copy full SHA for 0201daa

• fix incorrect syntax, ci-run-diff, ci-skip-unit-tests

  georgemccabe

  committed
  194088d

  Copy full SHA for 194088d

• handle failing comparison when NetCDF values are stored as a string, ci-run-diff, ci-skip-unit-tests

  georgemccabe

  committed
  8017d99

  Copy full SHA for 8017d99

• Preserve backwards compatibility by forcing TC_PAIRS_RUN_ONCE=False if LOOP_ORDER is still used and warn that it should be removed. Add debug log message to alert user that only the first init/vali…

  Show description for d7981f2
  georgemccabe

  committed
  d7981f2

  Copy full SHA for d7981f2

• Merge branch 'bugfix_gha_diff' of github.com:dtcenter/METplus into bugfix_gha_diff

  georgemccabe

  committed
  edbbe39

  Copy full SHA for edbbe39

• add pandas to diff conda environment used for diff tests in GHA to properly check for null/NaN values

  georgemccabe

  committed
  c8a80b2

  Copy full SHA for c8a80b2

• turn off use cases after tests succeeded

  georgemccabe

  committed
  353fd15

  Copy full SHA for 353fd15

Commits on Jun 15, 2023

• update apt-get to fix poppler-utils install error, add specific version for pandas

  georgemccabe

  committed
  52f5ceb

  Copy full SHA for 52f5ceb

• run use case to test that diff.v5.1 conda env was created properly, ci-run-diff

  georgemccabe

  committed
  1421c18

  Copy full SHA for 1421c18

• check if values are completely equal inside _is_equal_rounded function, call that function in NC value diff to prevent differences that are smaller than 5 decimal places

  georgemccabe

  committed
  b29a7ac

  Copy full SHA for b29a7ac

• turn off all use case groups before re-opening PR

  georgemccabe

  committed
  2b9bea5

  Copy full SHA for 2b9bea5

• if both netcdf values are masked, consider them equal

  georgemccabe

  committed
  0cbcff2

  Copy full SHA for 0cbcff2