Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix #1641 main_v4.1 StatAnalysis list format #1647

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Jun 7, 2022

Pull Request Testing

  • Describe testing already performed for these changes:

@CPKalb ran the use case that was previously failing with the changes from this branch and the issue was resolved.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Already completed.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by 6/10/2022.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…t are formatted as a string. These values are found in the above list of items that are formatted as a list, but the correct env var values are overwritten since they are included in this list incorrectly
@georgemccabe georgemccabe added this to the METplus-4.1.3 Bugfix milestone Jun 7, 2022
@georgemccabe georgemccabe requested a review from CPKalb June 7, 2022 14:43
@georgemccabe georgemccabe marked this pull request as ready for review June 7, 2022 15:52
Copy link
Contributor

@CPKalb CPKalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected

@georgemccabe georgemccabe merged commit 30e36e1 into main_v4.1 Jun 7, 2022
@georgemccabe georgemccabe deleted the bugfix_1641_main_v4.1_stat_analysis_lists branch June 7, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Bugfix: Add missing brackets around list variable values for StatAnalysis wrapper
2 participants