Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature 1431 remove obs_prepbufr_map #1433

Merged
merged 2 commits into from
Feb 10, 2022
Merged

feature 1431 remove obs_prepbufr_map #1433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1242297
Per #1431, remove support for setting obs_prepbufr_map in PB2NC becau…
georgemccabe Feb 9, 2022
51a22d1
Merge branch 'develop' into feature_1431_remove_obs_prepbufr_map
georgemccabe Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions docs/Users_Guide/glossary.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8593,11 +8593,6 @@ METplus Configuration Glossary

| *Used by:* PB2NC

PB2NC_OBS_PREPBUFR_MAP
Specify the value for 'obs_prepbufr_map' in the MET configuration file for PB2NC.

| *Used by:* PB2NC

POINT_STAT_HIRA_FLAG
Specify the value for 'hira.flag' in the MET configuration file for PointStat.

Expand Down
12 changes: 0 additions & 12 deletions docs/Users_Guide/wrappers.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4898,7 +4898,6 @@ METplus Configuration
| :term:`PB2NC_LEVEL_CATEGORY`
| :term:`PB2NC_QUALITY_MARK_THRESH`
| :term:`PB2NC_OBS_BUFR_MAP`
| :term:`PB2NC_OBS_PREPBUFR_MAP`

.. warning:: **DEPRECATED:**

Expand Down Expand Up @@ -5098,17 +5097,6 @@ see :ref:`How METplus controls MET config file settings<metplus-control-met>`.
* - :term:`PB2NC_OBS_BUFR_MAP`
- obs_bufr_map

**${METPLUS_OBS_PREPBUFR_MAP}**

.. list-table::
:widths: 5 5
:header-rows: 0

* - METplus Config(s)
- MET Config File
* - :term:`PB2NC_OBS_PREPBUFR_MAP`
- obs_prepbufr_map

.. _pcp_combine_wrapper:

PCPCombine
Expand Down
2 changes: 0 additions & 2 deletions internal_tests/pytests/pb2nc/test_pb2nc_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,8 +281,6 @@ def test_find_input_files(metplus_config, offsets, offset_to_find):
'vld_thresh = 0.1;}')}),
({'PB2NC_OBS_BUFR_MAP': '{key="POB"; val="PRES"; },{key="QOB"; val="SPFH";}', },
{'METPLUS_OBS_BUFR_MAP': 'obs_bufr_map = [{key="POB"; val="PRES"; }, {key="QOB"; val="SPFH";}];'}),
({'PB2NC_OBS_PREPBUFR_MAP': '{key="POB"; val="PRES"; },{key="QOB"; val="SPFH";}', },
{'METPLUS_OBS_PREPBUFR_MAP': 'obs_prepbufr_map = [{key="POB"; val="PRES"; }, {key="QOB"; val="SPFH";}];'}),

]
)
Expand Down
5 changes: 0 additions & 5 deletions metplus/wrappers/pb2nc_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ class PB2NCWrapper(CommandBuilder):
'METPLUS_LEVEL_CATEGORY',
'METPLUS_QUALITY_MARK_THRESH',
'METPLUS_OBS_BUFR_MAP',
'METPLUS_OBS_PREPBUFR_MAP',
]

def __init__(self, config, instance=None):
Expand Down Expand Up @@ -191,10 +190,6 @@ def create_c_dict(self):
data_type='list',
extra_args={'remove_quotes': True})

self.add_met_config(name='obs_prepbufr_map',
data_type='list',
extra_args={'remove_quotes': True})

return c_dict

def set_environment_variables(self, time_info):
Expand Down
1 change: 0 additions & 1 deletion parm/met_config/PB2NCConfig_wrapped
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ ${METPLUS_OBS_BUFR_MAP}
// This map is for PREPBUFR. It will be added into obs_bufr_map.
// Please do not override this map.
//obs_prepbufr_map =
${METPLUS_OBS_PREPBUFR_MAP}


////////////////////////////////////////////////////////////////////////////////
Expand Down
1 change: 0 additions & 1 deletion parm/use_cases/met_tool_wrapper/PB2NC/PB2NC.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,3 @@ PB2NC_TIME_SUMMARY_VALID_FREQ = 0
PB2NC_TIME_SUMMARY_VALID_THRESH = 0.0

#PB2NC_OBS_BUFR_MAP =
#PB2NC_OBS_PREPBUFR_MAP =