Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use STAGING_DIR rather than the TMP dir for series analysis wrappers #341

Closed
bikegeek opened this issue Dec 17, 2019 · 2 comments
Closed

Use STAGING_DIR rather than the TMP dir for series analysis wrappers #341

bikegeek opened this issue Dec 17, 2019 · 2 comments
Assignees
@bikegeek
Labels
component: python wrapper priority: high High Priority type: bug Fix something that is not working
Milestone
METplus-3.0 Release

Comments

@bikegeek
Copy link
Contributor

No description provided.

@bikegeek
Copy link
Contributor Author

Instead of using the TMP dir for storing the filtered output for the series_by_init_wrapper.py and series_by_lead_wrapper.py wrappers, save these files to the STAGING_DIR . Remove only files that are owned by the user, just in case the user uses a STAGING_DIR that is a common/shared directory.

@bikegeek bikegeek self-assigned this Dec 17, 2019
@bikegeek bikegeek added this to the METplus-3.0 Release milestone Dec 17, 2019
@bikegeek bikegeek added priority: high High Priority component: python wrapper type: bug Fix something that is not working labels Dec 17, 2019
bikegeek added a commit that referenced this issue Dec 17, 2019
@bikegeek
GitHub Issue #341 staging for series wrappers. Added function remove_…
560bb26 
…staged_files() to clean up any files owned by the current user in the STAGE_DIR that fits a particular

filenaming pattern.
bikegeek added a commit that referenced this issue Dec 17, 2019
@bikegeek
GitHub issue #341 series analysis staging. No longer use the TMP_DIR …
4119437 
…to store the filter_YYYYMMDD_HH_Storm files that

are created during filtering (and are temporary files).  Now save these to the user's STAGE DIR and clean up only the files
that start with 'filter' in the name and that are owned by the current user.
bikegeek added a commit that referenced this issue Dec 17, 2019
@bikegeek
GitHub issue #341 series analysis staging. As for the series_by_init_…
b102eae 
…wrapper.py, use the STAGE DIR rather than the TMP DIR to store the filter files and

clean up the STAGING DIR with any files that begin with 'filter' and that belong to the current user prior to exiting the wrapper.
bikegeek added a commit that referenced this issue Dec 17, 2019
@bikegeek
GitHub Issue #341 Removed tmp_dir references and replaced them with s…
e919917 
…taging_dir to explicitly show that the temporary filter files are going into the staging dir.
@bikegeek
Copy link
Contributor Author

Affected files:
-met_util.py (the addition of remove_staged_files(staged_dir, filename_regex, logger) to remove files based on filename pattern and only files that are owned by the current owner)
-README.rst (updated the description of what needs to be defined in the custom.conf file)
-To use the staging dir rather than the TMP dir and to use met_util.remove_staged_files() to remove files beginning with 'filter'
-series_by_lead_wrapper.py
-series_by_init_wrapper.py

Code committed and merged to the 'develop' branch

@bikegeek bikegeek mentioned this issue Dec 17, 2019
Closed
bikegeek added a commit that referenced this issue Dec 23, 2019
@bikegeek
Added test for test_met_util.py: test_remove_staged_files (which was …
f607843 
…added as part of Github issue #341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bikegeek bikegeek

Labels
component: python wrapper priority: high High Priority type: bug Fix something that is not working
Projects
None yet
Milestone
METplus-3.0 Release
Development

No branches or pull requests
1 participant
@bikegeek