Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hovmoeller Use case to use updated Hovmoeller plotting #1650

Closed
5 of 23 tasks
bikegeek opened this issue Jun 9, 2022 · 0 comments · Fixed by #1666
Closed
5 of 23 tasks

Update Hovmoeller Use case to use updated Hovmoeller plotting #1650

bikegeek opened this issue Jun 9, 2022 · 0 comments · Fixed by #1666
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue METplotpy: Plots METplus: Subseasonal to Seasonal priority: high High Priority required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing type: task An actionable item of work
Milestone

Comments

@bikegeek
Copy link
Contributor

bikegeek commented Jun 9, 2022

Replace italics below with details for this issue.

Describe the Task

The original METplotpy hovmoeller plot was not configurable for users who are running from the command line (and do not have permission to modify the code or to indicate where to save the output plot). Additionally, this code did not follow the paradigm that other METplotpy plots employed: default config file and custom config file. Instead, it was a mix of a "default" config file that couldn't be modified by some users (ie those that don't have permission to modify the source code that is installed in a common area) with command line arguments.

Time Estimate

Estimate the amount of work required here.
~2 days

Sub-Issues

Consider breaking the task down into sub-issues.

  • Update the hovmoeller.yaml config file to match the updated config file structure
  • Update/simplify the hovmoeller.py code, the METplotpy/metplotpy/plots/hovmoeller.py code has support for a custom configuration file to override the settings in the default.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) Minna Win, Hank Fisher
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority Assigned High priority because changes to hovmoeller code in METplotpy will be in the beta1 release
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@bikegeek bikegeek added type: enhancement Improve something that it is currently doing priority: high High Priority type: task An actionable item of work alert: NEED ACCOUNT KEY Need to assign an account key to this issue required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project METplus: Subseasonal to Seasonal METplotpy: Plots labels Jun 9, 2022
@bikegeek bikegeek added this to the METplus-5.0.0 milestone Jun 9, 2022
@bikegeek bikegeek self-assigned this Jun 9, 2022
@bikegeek bikegeek moved this from Todo to In Progress in METplus-Wrappers-5.0.0-beta1 (6/22/22) Jun 10, 2022
@bikegeek bikegeek moved this from To Do to In Progress in METplus-Analysis-5.0-beta1 (06/22/22) Jun 10, 2022
bikegeek added a commit that referenced this issue Jun 10, 2022
bikegeek added a commit that referenced this issue Jun 10, 2022
bikegeek added a commit that referenced this issue Jun 10, 2022
…tting script when supporting configurability
bikegeek added a commit that referenced this issue Jun 14, 2022
…ETplotpy source code so the PYTHONPATH set in the UserScript_obsPrecip_obsOnly_Hovmoeller.conf file will work
bikegeek added a commit that referenced this issue Jun 14, 2022
@bikegeek bikegeek moved this from In Progress to Pull Request Review in METplus-Analysis-5.0-beta1 (06/22/22) Jun 21, 2022
@georgemccabe georgemccabe moved this from In Progress to Review in METplus-Wrappers-5.0.0-beta1 (6/22/22) Jun 21, 2022
@bikegeek bikegeek moved this from Pull Request Review to Done in METplus-Analysis-5.0-beta1 (06/22/22) Jun 21, 2022
@georgemccabe georgemccabe linked a pull request Jun 22, 2022 that will close this issue
14 tasks
Repository owner moved this from Review to Done in METplus-Wrappers-5.0.0-beta1 (6/22/22) Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue METplotpy: Plots METplus: Subseasonal to Seasonal priority: high High Priority required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing type: task An actionable item of work
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants