Feature 642 distance map tb (#825)

Co-authored-by: Christina Kalb <kalb@kiowa.rap.ucar.edu>
Co-authored-by: George McCabe <mccabe@ucar.edu>

.github/workflows/main.yml

@@ -93,7 +93,9 @@ jobs:
           - "air_quality_and_comp"
           - "climate"
           - "convection_allowing_models:0-5"
-          - "convection_allowing_models:6+"
+          - "convection_allowing_models:6"
+          - "convection_allowing_models:7"
+          - "convection_allowing_models:8+"
           - "cryosphere"
           - "data_assimilation"
           - "marine_and_coastal"

ci/actions/run_tests/entrypoint.sh

@@ -51,20 +51,11 @@ pip_command="pip3 install Pillow"
 command="./ci/jobs/run_use_cases_docker.py ${CATEGORIES} ${SUBSETLIST}"
 
 # add input volumes to run command
-echo "Get Docker data volumes for input data"
-${GITHUB_WORKSPACE}/ci/jobs/get_data_volumes.py $CATEGORIES
-
 # keep track of --volumes-from arguments to docker run command
-VOLUMES_FROM=""
-
-# split list of categories by comma
-category_list=`echo $CATEGORIES | tr "," "\n"`
-
-# add input category --volumes-from arguments for docker run command
-for category in ${category_list}; do
-  VOLUMES_FROM=${VOLUMES_FROM}`echo --volumes-from $category" "`
-done
+echo "Get Docker data volumes for input data"
+VOLUMES_FROM=`${GITHUB_WORKSPACE}/ci/jobs/get_data_volumes.py $CATEGORIES`
 
+echo Input: ${VOLUMES_FROM}
 # get Docker data volumes for output data and run diffing logic
 # if running a pull request into develop or main_v* branches, not -ref branches
 if [ "$GITHUB_EVENT_NAME" == "pull_request" ] && [ "${GITHUB_BASE_REF: -4}" != "-ref" ] && ([ "${GITHUB_BASE_REF:0:7}" == "develop" ] || [ "${GITHUB_BASE_REF:0:6}" == "main_v" ]); then
@@ -73,9 +64,11 @@ if [ "$GITHUB_EVENT_NAME" == "pull_request" ] && [ "${GITHUB_BASE_REF: -4}" != "
   category=`${GITHUB_WORKSPACE}/ci/jobs/get_artifact_name.sh $INPUT_CATEGORIES`
   output_category=output-${GITHUB_BASE_REF}-${category}
 
-  ${GITHUB_WORKSPACE}/ci/jobs/get_data_volumes.py $output_category
-  new_volume=output-${category#use_cases_}
-  VOLUMES_FROM=${VOLUMES_FROM}`echo --volumes-from $new_volume" "`
+  echo Get output data volume: ${output_category}
+  OUT_VOLUMES_FROM=`${GITHUB_WORKSPACE}/ci/jobs/get_data_volumes.py $output_category`
+
+  echo Output: ${OUT_VOLUMES_FROM}
+  VOLUMES_FROM=${VOLUMES_FROM}" "$OUT_VOLUMES_FROM
 
   # add 3rd argument to command to trigger difference testing
   command=${command}" true"

ci/jobs/docker_setup.sh

@@ -2,7 +2,7 @@
 
 branch_name=`${GITHUB_WORKSPACE}/ci/jobs/print_branch_name.py`
 if [ "$GITHUB_EVENT_NAME" == "pull_request" ]; then
-  branch_name=${branch_name}-PR
+  branch_name=${branch_name}-pull_request
 fi
 
 #DOCKERHUB_TAG=dtcenter/metplus-dev:${DOCKER_IMAGE}

ci/jobs/get_data_volumes.py

@@ -90,14 +90,14 @@ def main(args):
 
         # if return code is non-zero, a failure occurred
         if ret.returncode:
-            return f'Command failed: {cmd}'
+            continue
 
         cmd = (f'docker create --name {model_app_name} '
                f'{repo_to_use}:{volume_name}')
         ret = subprocess.run(shlex.split(cmd), stdout=subprocess.DEVNULL)
 
         if ret.returncode:
-            return f'Command failed: {cmd}'
+            continue
 
         # add name to volumes from list to pass to docker build
         volume_list.append(f'--volumes-from {model_app_name}')

docs/use_cases/model_applications/convection_allowing_models/GridStat_fcstFV3_obsGOES_BrightnessTempDmap.py

@@ -0,0 +1,142 @@
+"""
+Grid-Stat: Brightness Temperature Distance Maps
+=========================================================================
+
+model_applications/
+convection_allowing_model/
+GridStat_fcstFV3_obsGOES_BrightnessTempDmap.conf
+
+"""
+##############################################################################
+# Scientific Objective
+# --------------------
+#
+# To provide statistical inforation on regions of low brightness temperatures,
+# defined by creating distance maps on the FV3 ensemble members compared to GOES
+# channel 13 brightness temperature satellite data.
+
+##############################################################################
+# Datasets
+# --------
+#
+#  * Forecast dataset: FV3 Model member data
+#  * Observation dataset: GOES Brightness Temperature
+#
+
+##############################################################################
+# METplus Components
+# ------------------
+#
+# This use case runs runs grid_stat to compute distance maps using a brightness
+# temperature less than 235 K for the forecast and observations.
+
+##############################################################################
+# METplus Workflow
+# ----------------
+#
+# The GridStat tool is run for each of 2 ensemble members and for each time.
+# This example loops by initialization time.  It processes 2 lead times, listed
+# below.
+#
+# | **Valid:** 2019-05-21_01Z
+# | **Forecast lead:** 01
+#
+# | **Valid:** 2019-05-21_02Z
+# | **Forecast lead:** 02
+
+##############################################################################
+# METplus Configuration
+# ---------------------
+#
+# METplus first loads all of the configuration files found in parm/metplus_config,
+# then it loads any configuration files passed to METplus via the command line
+# with the -c option, i.e. -c parm/use_cases/model_applications/convection_allowing_models/GridStat_fcstFV3_obsGOES_BrightnessTempDmap.conf
+#
+# .. highlight:: bash
+# .. literalinclude:: ../../../../parm/use_cases/model_applications/convection_allowing_models/GridStat_fcstFV3_obsGOES_BrightnessTempDmap.conf
+
+##############################################################################
+# MET Configuration
+# -----------------
+#
+# METplus sets environment variables based on user settings in the METplus configuration file.
+# See :ref:`How METplus controls MET config file settings<metplus-control-met>` for more details.
+#
+# **YOU SHOULD NOT SET ANY OF THESE ENVIRONMENT VARIABLES YOURSELF! THEY WILL BE OVERWRITTEN BY METPLUS WHEN IT CALLS THE MET TOOLS!**
+#
+# If there is a setting in the MET configuration file that is currently not supported by METplus you'd like to control, please refer to:
+# :ref:`Overriding Unsupported MET config file settings<met-config-overrides>`
+#
+# .. note:: See the :ref:`GridStat MET Configuration<grid-stat-met-conf>` section of the User's Guide for more information on the environment variables used in the file below:
+#
+# .. highlight:: bash
+# .. literalinclude:: ../../../../parm/met_config/GridStatConfig_wrapped
+
+##############################################################################
+# Running METplus
+# ---------------
+#
+# This use case can be run two ways:
+#
+# 1) Passing in GridStat_fcstFV3_obsGOES_BrightnessTempDmap.conf then a user-specific system configuration file::
+#
+#        run_metplus.py -c /path/to/METplus/parm/use_cases/model_applications/convection_allowing_models/GridStat_fcstFV3_obsGOES_BrightnessTempDmap.conf -c /path/to/user_system.conf
+#
+# 2) Modifying the configurations in parm/metplus_config, then passing in GridStat_fcstFV3_obsGOES_BrightnessTempDmap.conf::
+#
+#        run_metplus.py -c /path/to/METplus/parm/use_cases/model_applications/convection_allowing_models/GridStat_fcstFV3_obsGOES_BrightnessTempDmap.conf
+#
+# The former method is recommended. Whether you add them to a user-specific configuration file or modify the metplus_config files, the following variables must be set correctly:
+#
+# * **INPUT_BASE** - Path to directory where sample data tarballs are unpacked (See Datasets section to obtain tarballs). This is not required to run METplus, but it is required to run the examples in parm/use_cases
+# * **OUTPUT_BASE** - Path where METplus output will be written. This must be in a location where you have write permissions
+# * **MET_INSTALL_DIR** - Path to location where MET is installed locally
+#
+# Example User Configuration File::
+#
+#   [dir]
+#   INPUT_BASE = /path/to/sample/input/data
+#   OUTPUT_BASE = /path/to/output/dir
+#   MET_INSTALL_DIR = /path/to/met-X.Y
+#
+# **NOTE:** All of these items must be found under the [dir] section.
+#
+
+##############################################################################
+# Expected Output
+# ---------------
+#
+# A successful run will output the following both to the screen and to the logfile::
+#
+#   INFO: METplus has successfully finished running.
+#
+# Refer to the value set for **OUTPUT_BASE** to find where the output data was generated.
+# Output for this use case will be found in convection_allowing_models/brightness_temperature
+# (relative to **OUTPUT_BASE**) and will contain the following files:
+#
+# grid_stat/grid_stat_FV3_core_lsm1_000000L_20190521_010000V_dmap.txt
+# grid_stat/grid_stat_FV3_core_lsm1_000000L_20190521_010000V_pairs.nc
+# grid_stat/grid_stat_FV3_core_lsm1_000000L_20190521_010000V.stat
+# grid_stat/grid_stat_FV3_core_lsm1_000000L_20190521_020000V_dmap.txt
+# grid_stat/grid_stat_FV3_core_lsm1_000000L_20190521_020000V_pairs.nc
+# grid_stat/grid_stat_FV3_core_lsm1_000000L_20190521_020000V.stat
+# grid_stat/grid_stat_FV3_core_mp1_000000L_20190521_010000V_dmap.txt
+# grid_stat/grid_stat_FV3_core_mp1_000000L_20190521_010000V_pairs.nc
+# grid_stat/grid_stat_FV3_core_mp1_000000L_20190521_010000V.stat
+# grid_stat/grid_stat_FV3_core_mp1_000000L_20190521_020000V_dmap.txt
+# grid_stat/grid_stat_FV3_core_mp1_000000L_20190521_020000V_pairs.nc
+# grid_stat/grid_stat_FV3_core_mp1_000000L_20190521_020000V.stat
+
+
+##############################################################################
+# Keywords
+# --------
+#
+# sphinx_gallery_thumbnail_path = '_static/convection_allowing_models-GridStat_fcstFV3_obsGOES_BrightnessTempDmap.png'
+#
+# .. note:: `GridStatToolUseCase <https://dtcenter.github.io/METplus/search.html?q=GridStatToolUseCase&check_keywords=yes&area=default>`_,
+#  `ConvectionAllowingModelsAppUseCase <https://dtcenter.github.io/METplus/search.html?q=ConvectionAllowingModelsAppUseCase&check_keywords=yes&area=default>`_,
+#  `NetCDFFileUseCase <https://dtcenter.github.io/METplus/search.html?q=NetCDFFileUseCase&chek_keywords=yes&area=default>`_,
+#  `NOAAEMCOrgUseCase <https://dtcenter.github.io/METplus/search.html?q=NOAAEMCOrgUseCase&check_keywords=yes&area=default>`_,
+#  `NOAAHWTOrgUseCase  <https://dtcenter.github.io/METplus/search.html?q=NOAAHWTOrgUseCase&check_keywords=yes&area=default>`_,
+#  `ValidationUseCase  <https://dtcenter.github.io/METplus/search.html?q=ValidationUseCase&check_keywords=yes&area=default>`_

docs/use_cases/model_applications/convection_allowing_models/MODE_fcstFV3_obsGOES_BrightnessTempObjs.py

@@ -0,0 +1,170 @@
+"""
+MODE: Brightness Temperature Verification
+=========================================================================
+
+model_applications/
+convection_allowing_model/
+MODE_fcstFV3_obsGOES_BrightnessTempObjs.conf
+
+"""
+##############################################################################
+# Scientific Objective
+# --------------------
+#
+# To provide statistical inforation on regions of low brightness temperatures, 
+# defined by creating objects, in the FV3 ensemble members compared to GOES satellite. 
+# In addition, distance map information is computed for both the model and observation
+# using object based brightness temperatures
+
+##############################################################################
+# Datasets
+# --------
+#
+#  * Forecast dataset: FV3 Model member data
+#  * Observation dataset: GOES Brightness Temperature
+#
+
+##############################################################################
+# METplus Components
+# ------------------
+#
+# This use case runs MODE to create object statistics on brightness temperatures 
+# below 235 K. Then it runs grid_stat to compute neighborhood contingency table
+# counts and distance maps for the forecast and observations. 
+
+##############################################################################
+# METplus Workflow
+# ----------------
+#
+# The MODE and grid_stat tools are run for each of 2 ensemble members and for each
+# time. This example loops by initialization time.  It processes 2 lead times, listed 
+# below.
+#
+# | **Valid:** 2019-05-21_01Z
+# | **Forecast lead:** 01
+#
+# | **Valid:** 2019-05-21_02Z
+# | **Forecast lead:** 02
+
+##############################################################################
+# METplus Configuration
+# ---------------------
+#
+# METplus first loads all of the configuration files found in parm/metplus_config,
+# then it loads any configuration files passed to METplus via the command line
+# with the -c option, i.e. -c parm/use_cases/model_applications/convection_allowing_models/MODE_fcstFV3_obsGOES_BrightnessTempObjs.conf
+#
+# .. highlight:: bash
+# .. literalinclude:: ../../../../parm/use_cases/model_applications/convection_allowing_models/MODE_fcstFV3_obsGOES_BrightnessTempObjs.conf
+
+##############################################################################
+# MET Configuration
+# -----------------
+#
+# METplus sets environment variables based on user settings in the METplus configuration file.
+# See :ref:`How METplus controls MET config file settings<metplus-control-met>` for more details.
+#
+# **YOU SHOULD NOT SET ANY OF THESE ENVIRONMENT VARIABLES YOURSELF! THEY WILL BE OVERWRITTEN BY METPLUS WHEN IT CALLS THE MET TOOLS!**
+#
+# If there is a setting in the MET configuration file that is currently not supported by METplus you'd like to control, please refer to:
+# :ref:`Overriding Unsupported MET config file settings<met-config-overrides>`
+#
+# .. note:: See the :ref:`MODE MET Configuration<mode-met-conf>` section of the User's Guide for more information on the environment variables used in the file below:
+#
+# .. highlight:: bash
+# .. literalinclude:: ../../../../parm/met_config/MODEConfig_wrapped
+#
+# .. note:: See the :ref:`GridStat MET Configuration<grid-stat-met-conf>` section of the User's Guide for more information on the environment variables used in the file below:
+#
+# .. highlight:: bash
+# .. literalinclude:: ../../../../parm/met_config/GridStatConfig_wrapped
+
+##############################################################################
+# Running METplus
+# ---------------
+#
+# This use case can be run two ways:
+#
+# 1) Passing in MODE_fcstFV3_obsGOES_BrightnessTempObjs.conf then a user-specific system configuration file::
+#
+#        run_metplus.py -c /path/to/METplus/parm/use_cases/model_applications/convection_allowing_models/MODE_fcstFV3_obsGOES_BrightnessTempObjs.conf -c /path/to/user_system.conf
+#
+# 2) Modifying the configurations in parm/metplus_config, then passing in MODE_fcstFV3_obsGOES_BrightnessTempObjs.conf::
+#
+#        run_metplus.py -c /path/to/METplus/parm/use_cases/model_applications/convection_allowing_models/MODE_fcstFV3_obsGOES_BrightnessTempObjs.conf
+#
+# The former method is recommended. Whether you add them to a user-specific configuration file or modify the metplus_config files, the following variables must be set correctly:
+#
+# * **INPUT_BASE** - Path to directory where sample data tarballs are unpacked (See Datasets section to obtain tarballs). This is not required to run METplus, but it is required to run the examples in parm/use_cases
+# * **OUTPUT_BASE** - Path where METplus output will be written. This must be in a location where you have write permissions
+# * **MET_INSTALL_DIR** - Path to location where MET is installed locally
+#
+# Example User Configuration File::
+#
+#   [dir]
+#   INPUT_BASE = /path/to/sample/input/data
+#   OUTPUT_BASE = /path/to/output/dir
+#   MET_INSTALL_DIR = /path/to/met-X.Y 
+#
+# **NOTE:** All of these items must be found under the [dir] section.
+#
+
+##############################################################################
+# Expected Output
+# ---------------
+#
+# A successful run will output the following both to the screen and to the logfile::
+#
+#   INFO: METplus has successfully finished running.
+#
+# Refer to the value set for **OUTPUT_BASE** to find where the output data was generated.
+# Output for this use case will be found in convection_allowing_models/brightness_temperature 
+# (relative to **OUTPUT_BASE**) and will contain the following files:
+#
+# mode/mode_FV3_core_lsm1_010000L_20190521_010000V_NAA_cts.txt
+# mode/mode_FV3_core_lsm1_010000L_20190521_010000V_NAA_obj.nc
+# mode/mode_FV3_core_lsm1_010000L_20190521_010000V_NAA_obj.txt
+# mode/mode_FV3_core_lsm1_010000L_20190521_010000V_NAA.ps
+# mode/mode_FV3_core_lsm1_010000L_20190521_020000V_NAA_cts.txt
+# mode/mode_FV3_core_lsm1_010000L_20190521_020000V_NAA_obj.nc
+# mode/mode_FV3_core_lsm1_010000L_20190521_020000V_NAA_obj.txt
+# mode/mode_FV3_core_lsm1_010000L_20190521_020000V_NAA.ps
+# mode/mode_FV3_core_mp1_010000L_20190521_010000V_NAA_cts.txt
+# mode/mode_FV3_core_mp1_010000L_20190521_010000V_NAA_obj.nc
+# mode/mode_FV3_core_mp1_010000L_20190521_010000V_NAA_obj.txt
+# mode/mode_FV3_core_mp1_010000L_20190521_010000V_NAA.ps
+# mode/mode_FV3_core_mp1_010000L_20190521_020000V_NAA_cts.txt
+# mode/mode_FV3_core_mp1_010000L_20190521_020000V_NAA_obj.nc
+# mode/mode_FV3_core_mp1_010000L_20190521_020000V_NAA_obj.txt
+# mode/mode_FV3_core_mp1_010000L_20190521_020000V_NAA.ps
+# grid_stat_obj/grid_stat_FV3_core_lsm1_000000L_20190521_010000V_dmap.txt
+# grid_stat_obj/grid_stat_FV3_core_lsm1_000000L_20190521_010000V_nbrctc.txt
+# grid_stat_obj/grid_stat_FV3_core_lsm1_000000L_20190521_010000V_pairs.nc
+# grid_stat_obj/grid_stat_FV3_core_lsm1_000000L_20190521_010000V.stat
+# grid_stat_obj/grid_stat_FV3_core_lsm1_000000L_20190521_020000V_dmap.txt
+# grid_stat_obj/grid_stat_FV3_core_lsm1_000000L_20190521_020000V_nbrctc.txt
+# grid_stat_obj/grid_stat_FV3_core_lsm1_000000L_20190521_020000V_pairs.nc
+# grid_stat_obj/grid_stat_FV3_core_lsm1_000000L_20190521_020000V.stat
+# grid_stat_obj/grid_stat_FV3_core_mp1_000000L_20190521_010000V_dmap.txt
+# grid_stat_obj/grid_stat_FV3_core_mp1_000000L_20190521_010000V_nbrctc.txt
+# grid_stat_obj/grid_stat_FV3_core_mp1_000000L_20190521_010000V_pairs.nc
+# grid_stat_obj/grid_stat_FV3_core_mp1_000000L_20190521_010000V.stat
+# grid_stat_obj/grid_stat_FV3_core_mp1_000000L_20190521_020000V_dmap.txt
+# grid_stat_obj/grid_stat_FV3_core_mp1_000000L_20190521_020000V_nbrctc.txt
+# grid_stat_obj/grid_stat_FV3_core_mp1_000000L_20190521_020000V_pairs.nc
+# grid_stat_obj/grid_stat_FV3_core_mp1_000000L_20190521_020000V.stat
+
+
+##############################################################################
+# Keywords
+# --------
+#
+# sphinx_gallery_thumbnail_path = '_static/convection_allowing_models-MODE_fcstFV3_obsGOES_BrightnessTempObjs.png'
+#
+# .. note:: `MODEToolUseCase <https://dtcenter.github.io/METplus/search.html?q=MODEToolUseCase&check_keywords=yes&area=default>`_,
+#  `GridStatToolUseCase <https://dtcenter.github.io/METplus/search.html?q=GridStatToolUseCase&check_keywords=yes&area=default>`_,
+#  `ConvectionAllowingModelsAppUseCase <https://dtcenter.github.io/METplus/search.html?q=ConvectionAllowingModelsAppUseCase&check_keywords=yes&area=default>`_,
+#  `NetCDFFileUseCase <https://dtcenter.github.io/METplus/search.html?q=NetCDFFileUseCase&chek_keywords=yes&area=default>`_,
+#  `NOAAEMCOrgUseCase <https://dtcenter.github.io/METplus/search.html?q=NOAAEMCOrgUseCase&check_keywords=yes&area=default>`_,
+#  `NOAAHWTOrgUseCase  <https://dtcenter.github.io/METplus/search.html?q=NOAAHWTOrgUseCase&check_keywords=yes&area=default>`_,
+#  `ValidationUseCase  <https://dtcenter.github.io/METplus/search.html?q=ValidationUseCase&check_keywords=yes&area=default>`_

internal_tests/use_cases/all_use_cases.txt

@@ -66,6 +66,9 @@ GridStat_fcstHRRR_obsPracPerfect_SurrogateSevere::model_applications/convection_
 GridStat_fcstHRRR_obsPracPerfect_SurrogateSevereProb::model_applications/convection_allowing_models/GridStat_fcstHRRR_obsPracPerfect_SurrogateSevereProb.conf
 Point2Grid_obsLSR_ObsOnly_PracticallyPerfect::model_applications/convection_allowing_models/Point2Grid_obsLSR_ObsOnly_PracticallyPerfect.conf
 MODE_fcstFV3_obsGOES_BrightnessTemp::model_applications/convection_allowing_models/MODE_fcstFV3_obsGOES_BrightnessTemp.conf,model_applications/convection_allowing_models/MODE_fcstFV3_obsGOES_BrightnessTemp/ci_overrides.conf
+MODE_fcstFV3_obsGOES_BrightnessTempObjs:: model_applications/convection_allowing_models/MODE_fcstFV3_obsGOES_BrightnessTempObjs.conf
+GridStat_fcstFV3_obsGOES_BrightnessTempDmap:: model_applications/convection_allowing_models/GridStat_fcstFV3_obsGOES_BrightnessTempDmap.conf
+
 
 Category:cryosphere
 GridStat_MODE_fcstIMS_obsNCEP_sea_ice::model_applications/cryosphere/GridStat_MODE_fcstIMS_obsNCEP_sea_ice.conf