Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Plots for the Stratosphere Diagnostics #170

Closed
10 of 21 tasks
CPKalb opened this issue Nov 12, 2021 · 3 comments · Fixed by #191
Closed
10 of 21 tasks

Create Plots for the Stratosphere Diagnostics #170

CPKalb opened this issue Nov 12, 2021 · 3 comments · Fixed by #191
Assignees
Labels
reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: NOAA/other NOAA Laboratory, not otherwise specified type: new feature Make it do something new

Comments

@CPKalb
Copy link
Contributor

CPKalb commented Nov 12, 2021

Replace italics below with details for this issue.

Describe the New Feature

Examples of the needed plots are included below. Note that we are using different data than what was used in those plots, so the output shouldn't match. Specifically, the first plot is zonal mean wind (left) and temperature (right). The lines are averages from the observations, and the contours are biases (as will be output from series_analysis). The second is rmse and bias averaged between 60 and 90 degrees and over time.

Acceptance Testing

Output from series_analysis will be added here when it is available

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2793541

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@CPKalb CPKalb added type: new feature Make it do something new alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Nov 12, 2021
@CPKalb
Copy link
Contributor Author

CPKalb commented Nov 12, 2021

unnamed

@CPKalb
Copy link
Contributor Author

CPKalb commented Nov 12, 2021

unnamed (1)

@CPKalb CPKalb added requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: NOAA/other NOAA Laboratory, not otherwise specified labels Nov 12, 2021
@CPKalb
Copy link
Contributor Author

CPKalb commented Nov 12, 2021

@bikegeek bikegeek removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Jan 20, 2022
@bikegeek bikegeek added this to the METplotpy-1.1 milestone Jan 20, 2022
bikegeek added a commit that referenced this issue Jan 22, 2022
bikegeek added a commit that referenced this issue Jan 25, 2022
bikegeek added a commit that referenced this issue Jan 25, 2022
… pre_processing directional_means.py module
@bikegeek bikegeek removed the alert: NEED MORE DEFINITION Not yet actionable, additional definition required label Jan 26, 2022
bikegeek added a commit that referenced this issue Jan 27, 2022
bikegeek added a commit that referenced this issue Jan 27, 2022
bikegeek added a commit that referenced this issue Jan 27, 2022
bikegeek added a commit that referenced this issue Jan 27, 2022
@bikegeek bikegeek linked a pull request Jan 27, 2022 that will close this issue
12 tasks
@TaraJensen TaraJensen added the reporting: DTC NOAA R2O NOAA Research to Operations DTC Project label Feb 2, 2022
bikegeek added a commit that referenced this issue Feb 8, 2022
bikegeek added a commit that referenced this issue Feb 8, 2022
* Issue #170 initial commit. Enables importing of this module

* feature #170 initial commit. Only reads in an empty yaml config file

* Issue #170 initial commit, empty file

* Issue #170 pyzome package from Zack Lawrence (CIRES/CU, NOAA/PSL)

* Issue #170 completed config file for generating all four plots in the original code from NOAA

* Issue #170 didn't need pyzome, this code is replaced in the METcalcpy pre_processing directional_means.py module

* Delete stratospheric_diagnostics_plot.py

renamed stratosphere_diagnostics.py

* Issue #170 replace hard-coded paths with the generic path/to

* Issue #170 first draft

* Issue #170 updates based on changes to setting name changes in the yaml file

* Issue #170 reorganized settings and renamed some settings for clarity

* Issue #170 uncommented calls to some plots, now all plots will be generated

* Issue #170 added to TOC

* Issue #170 updates to documentation

* Issue #170 plots to be generated

* Issue #170 fixed inconsistency with input data directory

* Issue #170 fixed bad grammar

Co-authored-by: Minna Win <minnawin@kiowa.rap.ucar.edu>
@bikegeek bikegeek closed this as completed Feb 8, 2022
bikegeek added a commit that referenced this issue Mar 10, 2022
bikegeek added a commit that referenced this issue Mar 11, 2022
* replaced incorrectly hard-coded path to data to reflect new location of data

* Issue #172 update and corrections

* #172 add sample hovmoeller plot

* #172 add difficulty index to toc

* #172 initial version of difficulty index doc

* #172 fixed formatting

* #172 update yaml file

* updating actions

* #172 content for difficulty index

* #172 new content for ECLV plot

* #172 added ECLV to toc

* #172 added references for ECLV

* fixed import, looks like some parts got accidentally removed

* replaced missing portion of import statements

* fixed import statement, looks like some of it was removed

* still missing some portion of import

* replace wind_rose_default.png with wind_rose_custom.png for plot_filename so it is consistent with the other plots' user instructions

* replaced name of output plot to reflect change of output plot name in the wind_rose_custom.yaml config file

* update the METPLOTPY_BASE to reflect changes made to base_plot.py in beta6

* added wind rose to toc

* #172 added files for wind rose documentation

* update the METPLOTPY_BASE to reflect changes to base_plot.py in beta6

* #172 missing instructions for csh

* #172 additional config file for User's Guide

* #172 missed one place to update the METPLOTPY_BASE

* updated METPLOTPY_BASE in test setup, allowing all tests to be run.

* updated imports to reflect changes made in beta6 to base_plot.py and fixed code that wasn't working

* Update unit_tests.yaml

adding the relative frequency, rank, and probability histogram tests.

* skip the image comparison tests, these are unreliable when run on different hosts/environments

* fixed incorrect syntax for skipping tests

* #172 add histogram to the toc

* #172 files needed for histogram documentation

* #172 updates to line plot documentation for users that downloaded the source code, rather than forking or cloning.  The base/root directory of the METplotpy package will be different

* #172 clean up repetitive text and reformat

* #172 replace METPLOTPY_SOURCE/METplotpy with METPLOTPY_BASE and update instructions to reflect this change

* #172 update config files to include the points_path (commented out) to be consistent with the other plots that have intermediate points and to be consistent with the instructions in the user documentation

* #172 added the points_path setting to the custom config

* #172 add points_path

* #172 updates to instructions, replacing METPLOTPY_SOURCE with METPLOTPY_BASE due to changes to base_plot.py

* #172 fix imports

* #172 updates to histogram_2d documentation

* #172 updates to hovmoeller path

* #172 updates to paths

* #172 update to path

* update path to read the docs

* add stat_input and points_path settings to config file to work for the user documentation

* updates to paths

* add config file and support to indicate where to put input data file and output data

* updates from another issue to fix histogram plots

* #172 added support to indicate where to store output plots

* skip image comparison tests, these fail in the Github actions container

* update with latest changes

* #172 try using metplotpy.plots instead of relative paths for imports

* Update unit_tests.yaml

troubleshooting histogram tests

* fix METPLOTPY_BASE

* change path to METPLOTPY_BASE, remove one level

* clean up imports

* clean up METPLOTPY_BASE paths

* uncomment remaining two histogram tests

* update reason for skip tests

* Added polar plot documentation with images

* added missing items to TOC

* added wind-rose plot to TOC

* Spelled ice correctly

* Removed incorrectly spelled file

* added terminating *

* added histogram to TOC

* #172 remove extraneous character

* #172 include path to the example_difficulty_index.py script

* #172 replace METPLOTPY_SOURCE with METPLOTPY_BASE

* #172 replace METPLOTPY_SOURCE with METPLOTPY_BASE

* #172 Replace METPLOTPY_BASE_DIR wieh METPLOTPY_BASE

* #172 replace METPLOTPY_SOURCE with METPLOTPY_BASE

* #172 replaced Polar Plot plot with Polar Ice plot and fixed some other rst syntax

* #170 fixed header for polar ice plot

* #172 removed redundant histogram entry in TOC

* #172 fixed title overline length to polar plot

* #172 update instructions for users that need to save output to another location

* #172 fixed name of the polar plot yaml name

* fixed path to config file

* #172 modify the command line to not specify another config file

* #172 update instruction on METPLOTPY_BASE

* #172 replace incorrect yaml name with correct one, polar_ice.yaml

* #172 modify instructions to change to WORKING_DIR and to run from that dir

* #172 fix formatting for code block

* #172 removed reference to a default config file and more clarification about what the polar_ice_plot.py plot is using for config

* #172 add entry for the points_path since dump_points is set to True in the default config file

* #172 added more explicit directions for replacing the METPLOTPY_BASE with the explicit path

Co-authored-by: Minna Win <minnawin@kiowa.rap.ucar.edu>
Co-authored-by: Hank Fisher <fisherh@ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: NOAA/other NOAA Laboratory, not otherwise specified type: new feature Make it do something new
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants