Feature 234 rrfs linetypes

[bikegeek]

Pull Request Testing

• Describe testing already performed for these changes:
  

• successfully ran pytest tests in METdataio/METreformat/test

• manually generated reformatted RHIST, PCT , ECNT data, VCNT, MCTS, and VL1L2 line type data
  - ran successive times to ensure proper behavior for issue Bugfix remove existing output and update documentation reflecting change #232 (remove existing output if it already exists and write to new file)
  - using data from
  - METdataio/METreformat/test/data/rhis_phist_relp_orank and RHIST.yaml in METdataio/METreformat/test
  - METdataio/METreformat/test/data/ensemble_stat, grid_stat, point_stat and CNT.yaml, CTC.yaml, CTS.yaml, FHO.yaml, MCTS.yaml, VCNT.yaml, SL1L2.yaml, VL1L2.yaml to reflect refactored behavior of write_stat_ascii.py

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

  use the following Python versions on 'seneca' for the metplus_analysis_env:
       /home/minnawin/.conda/envs/metplus_analysis_env
  
      or use this to create your own (remove the .txt extension) :
                   [metplus_analysis_env.yaml.txt](https://github.com/dtcenter/METdataio/files/13532482/metplus_analysis_env.yaml.txt)
  
             conda env create -f metplus_analysis_env.yaml
  

  • Using data in METdataio/METreformat/test/data/RRFS_PCT_PRC_PJC_PSTD for
    PCT and ECNT line types
    METdataio/METreformat/test/data/rhist_phist_relp_orank for RHIST line type

  Generating reformatted data:

  • modify the paths in the METdataio/METreformat/test/RHIST.yaml, METdataio/METreformat/test/ECNT.yaml
  • METdataio/METreformat/test/PCT.yaml (or any other yaml file)

  Run the following command from the command line:

  • python /path/to/METdataio/METreformat/write_stat_ascii.py /path/to/METdataio/METreformat/

For Engineer (Hank)

• verify that the instructions in the documentation Read the Docs is correct 
   -      https://metdataio.readthedocs.io/en/feature_234_rrfs_linetypes/Users_Guide/reformat_stat_data.html
  

•  pytests pass in METdataio/METreformat/test/test_reformatting.py
   -  from METdataio/METreformat/test:
   -     pytest test_reformatting.py           
  

For Scientist (Vanderlei)

• verify that the instructions in the documentation Read the Docs is correct 
  -       https://metdataio.readthedocs.io/en/feature_234_rrfs_linetypes/Users_Guide/reformat_stat_data.html
  

• using your own data with RHIST, ECNT, and PCT line types, ensure that the reformatted data contains the necessary data for generating plots of interest
  

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes ]

• Do these changes include sufficient testing updates? [Yes]

• Will this PR result in changes to the test suite? [ No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Earliest convenience].
  

Pull Request Checklist

See the METplus Workflow for details.

• Add any new Python packages to the METplus Components Python Requirements table.
• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[hankenstein2]

Looks great! I made a very small formatting fix in one of the rst files