Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages for when multiple files are not loaded #35

Closed
19 tasks
venitahagerty opened this issue Aug 20, 2020 · 1 comment
Closed
19 tasks
Assignees
Labels
type: enhancement Improve something that it is currently doing

Comments

@venitahagerty
Copy link
Contributor

Replace italics below with details for this issue.

Describe the Enhancement

In order to speed up processing in Python, multiple files are processed together as a batch. Transformations - like calculating fcst_init - are done at once for all of the files of the batch. This makes it difficult to give a message for which file had the error. In addition, determining which file had the error may increase processing time. A solution needs to be found that will improve error messaging for users without increasing processing time too much.

Time Estimate

3 days of work.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones
  • Select milestone

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop and link the pull request to this issue.
    Pull request: feature <Issue Number> <Description>
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@venitahagerty venitahagerty added the type: enhancement Improve something that it is currently doing label Aug 20, 2020
@venitahagerty venitahagerty self-assigned this Aug 20, 2020
@jprestop jprestop moved this to 🏗 In progress in METplus-Analysis-6.0.0 Development Jul 17, 2024
@jprestop jprestop added this to the METdataio-3.0.0 milestone Jul 17, 2024
@jprestop jprestop moved this from 🏗 In progress to 🛑 Stalled in METplus-Analysis-6.0.0 Development Jul 17, 2024
@mollybsmith-noaa
Copy link
Contributor

I'm closing this issue because I added a try/catch in the middle of the data read loop, so one bad file will no longer cause lots of good files not to be loaded. See #295

@github-project-automation github-project-automation bot moved this from 🛑 Stalled to ✅ Done in METplus-Analysis-6.0.0 Development Jul 18, 2024
@jprestop jprestop changed the title Provide better error messages for when an error causes multiple files not to be loaded Improve error messages for when multiple files are not loaded Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improve something that it is currently doing
Projects
No open projects
Status: 🏁 Done
Development

No branches or pull requests

3 participants