Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_files.py needs try/excepts inside of loops #295

Closed
mollybsmith-noaa opened this issue Apr 10, 2024 · 0 comments
Closed

read_files.py needs try/excepts inside of loops #295

mollybsmith-noaa opened this issue Apr 10, 2024 · 0 comments
Assignees
Labels
component: METdataio reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NOAA/GSL NOAA Global Systems Laboratory type: bug Fix something that is not working

Comments

@mollybsmith-noaa
Copy link
Contributor

Describe the Problem

In read_files.py, there's a try/except outside of the main read loop (line 88), but not within the loop itself (line 120). This means that if read_files.py encounters a bad file within the loop, it throws out all of the files within that batch instead of just the one.

Expected Behavior

The script should fail to an except within the loop, which results in only the one bad file being discarded.

@mollybsmith-noaa mollybsmith-noaa added requestor: NOAA/GSL NOAA Global Systems Laboratory type: bug Fix something that is not working reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project component: METdataio labels Apr 10, 2024
@mollybsmith-noaa mollybsmith-noaa self-assigned this Apr 10, 2024
@mollybsmith-noaa mollybsmith-noaa added this to the METdataio-3.0.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: METdataio reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NOAA/GSL NOAA Global Systems Laboratory type: bug Fix something that is not working
Projects
None yet
Development

No branches or pull requests

2 participants