Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement aggregation of CRPS_EMP_FAIR across multiple cases #215 #230

Merged
merged 4 commits into from
Nov 2, 2022

Conversation

TatianaBurek
Copy link
Collaborator

Pull Request Testing

To test use instructions from dtcenter/METviewer#435

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@TatianaBurek TatianaBurek added this to the METcalcpy-2.0 milestone Nov 2, 2022
@TatianaBurek TatianaBurek linked an issue Nov 2, 2022 that may be closed by this pull request
21 tasks
Co-authored-by: johnhg <johnhg@ucar.edu>
TatianaBurek and others added 2 commits November 2, 2022 10:43
Co-authored-by: johnhg <johnhg@ucar.edu>
Co-authored-by: johnhg <johnhg@ucar.edu>
Copy link
Contributor

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes.

I see that the logic of the newly added calculate_ecnt_crps_emp_fair() function matches the logic of the existing calculate_ecnt_crps_emp() function. And they should be handled the same way.

Since many statistics are aggregated as weighted averages like this, perhaps this similar logic could be factored out into a utility function for fewer lines of code to maintain? But the logic of the code as written, looks correct to me.

@TatianaBurek TatianaBurek merged commit 61dad50 into develop Nov 2, 2022
@TatianaBurek TatianaBurek deleted the issue_215_CRPS_EMP_FAIR branch November 2, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Implement aggregation of CRPS_EMP_FAIR across multiple cases
2 participants