Update main_v11.0-ref after 11.0.3 release (#2678)

.github/ISSUE_TEMPLATE/bug_report.md

@@ -2,7 +2,7 @@
 name: Bug report
 about: Fix something that's not working
 title: 'Bugfix: '
-labels: 'alert: NEED ACCOUNT KEY, alert: NEED MORE DEFINITION, alert: NEED PROJECT ASSIGNMENT, type: bug'
+labels: 'alert: NEED ACCOUNT KEY, alert: NEED MORE DEFINITION, alert: NEED CYCLE ASSIGNMENT, type: bug'
 assignees: ''
 
 ---
@@ -49,7 +49,7 @@ Describe the steps to reproduce the behavior:
 
 ### Projects and Milestone ###
 - [ ] Select **Organization** level **Project** for support of the current coordinated release
-- [ ] Select **Repository** level **Project** for development toward the next official release or add **alert: NEED PROJECT ASSIGNMENT** label
+- [ ] Select **Repository** level **Project** for development toward the next official release or add **alert: NEED CYCLE ASSIGNMENT** label
 - [ ] Select **Milestone** as the next bugfix version
 
 ## Define Related Issue(s) ##

.github/ISSUE_TEMPLATE/enhancement_request.md

@@ -2,7 +2,7 @@
 name: Enhancement request
 about: Improve something that it's currently doing
 title: ''
-labels: 'alert: NEED ACCOUNT KEY, alert: NEED MORE DEFINITION, alert: NEED PROJECT ASSIGNMENT, type: enhancement'
+labels: 'alert: NEED ACCOUNT KEY, alert: NEED MORE DEFINITION, alert: NEED CYCLE ASSIGNMENT, type: enhancement'
 assignees: ''
 
 ---
@@ -38,7 +38,7 @@ Consider breaking the enhancement down into sub-issues.
 - [ ] Select **requestor(s)**
 
 ### Projects and Milestone ###
-- [ ] Select **Repository** and/or **Organization** level **Project(s)** or add **alert: NEED PROJECT ASSIGNMENT** label
+- [ ] Select **Repository** and/or **Organization** level **Project(s)** or add **alert: NEED CYCLE ASSIGNMENT** label
 - [ ] Select **Milestone** as the next official version or **Future Versions**
 
 ## Define Related Issue(s) ##

.github/ISSUE_TEMPLATE/new_feature_request.md

@@ -2,7 +2,7 @@
 name: New feature request
 about: Make it do something new
 title: ''
-labels: 'alert: NEED ACCOUNT KEY, alert: NEED MORE DEFINITION, alert: NEED PROJECT ASSIGNMENT, type: new feature'
+labels: 'alert: NEED ACCOUNT KEY, alert: NEED MORE DEFINITION, alert: NEED CYCLE ASSIGNMENT, type: new feature'
 assignees: ''
 
 ---
@@ -42,7 +42,7 @@ Consider breaking the new feature down into sub-issues.
 - [ ] Select **requestor(s)**
 
 ### Projects and Milestone ###
-- [ ] Select **Repository** and/or **Organization** level **Project(s)** or add **alert: NEED PROJECT ASSIGNMENT** label
+- [ ] Select **Repository** and/or **Organization** level **Project(s)** or add **alert: NEED CYCLE ASSIGNMENT** label
 - [ ] Select **Milestone** as the next official version or **Future Versions**
 
 ## Define Related Issue(s) ##

.github/ISSUE_TEMPLATE/sub-issue.md

@@ -2,7 +2,7 @@
 name: Sub-Issue
 about: Break an issue down into smaller parts
 title: ''
-labels: 'alert: NEED ACCOUNT KEY, alert: NEED MORE DEFINITION, alert: NEED PROJECT ASSIGNMENT, type: sub-issue'
+labels: 'alert: NEED ACCOUNT KEY, alert: NEED MORE DEFINITION, alert: NEED CYCLE ASSIGNMENT, type: sub-issue'
 assignees: ''
 
 ---
@@ -28,5 +28,5 @@ This is a sub-issue of #*List the parent issue number here*.
 - [ ] Select **requestor(s)**
 
 ### Projects and Milestone ###
-- [ ] Select **Repository** and/or **Organization** level **Project(s)** or add **alert: NEED PROJECT ASSIGNMENT** label
+- [ ] Select **Repository** and/or **Organization** level **Project(s)** or add **alert: NEED CYCLE ASSIGNMENT** label
 - [ ] Select **Milestone** as the next official version or **Future Versions**

.github/ISSUE_TEMPLATE/task.md

@@ -2,7 +2,7 @@
 name: Task
 about: Describe something that needs to be done
 title: ''
-labels: 'alert: NEED ACCOUNT KEY, alert: NEED MORE DEFINITION, alert: NEED PROJECT ASSIGNMENT, type: task'
+labels: 'alert: NEED ACCOUNT KEY, alert: NEED MORE DEFINITION, alert: NEED CYCLE ASSIGNMENT, type: task'
 assignees: ''
 
 ---
@@ -38,7 +38,7 @@ Consider breaking the task down into sub-issues.
 - [ ] Select **requestor(s)**
 
 ### Projects and Milestone ###
-- [ ] Select **Repository** and/or **Organization** level **Project(s)** or add **alert: NEED PROJECT ASSIGNMENT** label
+- [ ] Select **Repository** and/or **Organization** level **Project(s)** or add **alert: NEED CYCLE ASSIGNMENT** label
 - [ ] Select **Milestone** as the next official version or **Future Versions**
 
 ## Define Related Issue(s) ##

.github/workflows/testing.yml

@@ -14,15 +14,25 @@ on:
       - 'bugfix_**'
     paths-ignore:
       - 'docs/**'
-
+      - '.github/pull_request_template.md'
+      - '.github/ISSUE_TEMPLATE/**'
+      - '.github/labels/**'
+      - '**/README.md'
+      - '**/LICENSE.md'
+
   pull_request:
     types: [opened, reopened, synchronize]
     branches:
       - develop
       - 'main_v**'
     paths-ignore:
       - 'docs/**'
-
+      - '.github/pull_request_template.md'
+      - '.github/ISSUE_TEMPLATE/**'
+      - '.github/labels/**'
+      - '**/README.md'
+      - '**/LICENSE.md'
+
   workflow_dispatch:
     inputs:
       force_tests:

.github/workflows/update_truth.yml

@@ -0,0 +1,59 @@
+name: Update Truth Data
+
+on:
+  workflow_dispatch:
+    inputs:
+      pull_requests:
+        description: 'Pull request(s) that warranted update, e.g. "#123" or "#123 and dtcenter/MET#123"'
+        required: true
+      change_summary:
+        description: 'Summary of changes to truth data'
+        required: true
+
+jobs:
+  update_truth:
+    name: "Update or create truth reference branch"
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check if branch is develop or main_vX.Y
+        run: |
+          branch_name=${GITHUB_REF#refs/heads/}
+          echo "branch_name=$branch_name" >> $GITHUB_ENV
+          if [[ $branch_name == "develop" ]] || \
+             [[ $branch_name =~ ^main_v[0-9]+\.[0-9]+$ ]]; then
+            echo Branch is valid - $branch_name
+            exit 0
+          fi
+          echo ERROR: Branch is $branch_name - must be develop or match main_vX.Y
+          exit 1
+      - uses: actions/checkout@v3
+        name: Checkout repository
+        with:
+          fetch-depth: 0
+          token: ${{ secrets.METPLUS_BOT_TOKEN }}
+      - name: Resolve conflicts between branch and branch-ref
+        run: |
+          branch_name=${{ env.branch_name }}
+          cd ${GITHUB_WORKSPACE}
+          if [[ -z "$(git ls-remote --heads origin ${branch_name}-ref)" ]]; then
+            echo ERROR: ${branch_name}-ref does not exist
+            exit 1
+          fi
+
+          echo ${branch_name}-ref does exist -- update it
+          git config --global user.name "metplus-bot"
+          git config --global user.email "97135045+metplus-bot@users.noreply.github.com"
+          echo git checkout ${branch_name}
+          git checkout ${branch_name}
+          echo git merge -s ours origin/${branch_name}-ref
+          git merge -s ours origin/${branch_name}-ref
+          echo git push origin ${branch_name}
+          git push origin ${branch_name}
+
+      - name: Create Pull Request
+        run: gh pr create --base $BASE --body "$BODY" --title "$TITLE"
+        env:
+          GH_TOKEN: ${{ github.token }}
+          BASE: ${{ env.branch_name }}-ref
+          BODY: ${{ github.event.inputs.change_summary }}<br/>Created by @${{ github.actor}}
+          TITLE: Update ${{ env.branch_name }}-ref after ${{ github.event.inputs.pull_requests }}

.readthedocs.yaml

@@ -9,10 +9,14 @@ version: 2
 #formats: all
 formats: [pdf]
 
+build:
+  os: ubuntu-22.04
+  tools:
+    python: "3.10"
+
 # Optionally set the version of Python and requirements required to build your
 # docs
 python:
-   version: 3.7
    install:
    - requirements: docs/requirements.txt
 

docs/Users_Guide/release-notes.rst

@@ -10,6 +10,22 @@ enhancement, or new feature (`MET GitHub issues <https://github.com/dtcenter/MET
 Important issues are listed **in bold** for emphasis.
 
 
+MET Version 11.0.3 release notes (20230908)
+-------------------------------------------
+
+.. note::
+   Version 11.0.3 is the final planned bugfix release for MET version 11.0. Please upgrade to a
+   newer version for additional bugfixes and enhancements and see the METplus
+   `release support policy <https://metplus.readthedocs.io/en/latest/Release_Guide/index.html#release-support-policy>`_
+   for additional details.
+
+* Bugfixes:
+
+   * Bugfix: Fix the Clang compilation of MET version 11.0 (`#2514 <https://github.com/dtcenter/MET/issues/2514>`_).
+   * Bugfix: Fix logic for Python embedding with data censoring and/or conversion (`#2575 <https://github.com/dtcenter/MET/issues/2575>`_).
+   * Bugfix: Fix reading of upside-down CF-compliant NetCDF Rotated Lat/Lon data (`#2578 <https://github.com/dtcenter/MET/issues/2578>`_).
+   * Bugfix: Fix logic for computing the 100-th percentile (`#2644 <https://github.com/dtcenter/MET/issues/2644>`_).
+
 MET Version 11.0.2 release notes (20230331)
 -------------------------------------------
 

docs/Users_Guide/stat-analysis.rst

@@ -282,7 +282,7 @@ The usage statement for the Stat-Analysis tool is shown below:
 
 stat_analysis has two required arguments and accepts several optional ones. 
 
-In the usage statement for the Stat-Analysis tool, some additional terminology is introduced. In the Stat-Analysis tool, the term "job" refers to a set of tasks to be performed after applying user-specified options (i.e., "filters"). The filters are used to pare down a collection of output from the MET statistics tools to only those lines that are desired for the analysis. The job and its filters together comprise the "job command line". The "job command line" may be specified either on the command line to run a single analysis job or within the configuration file to run multiple analysis jobs at the same time. If jobs are specified in both the configuration file and the command line, only the jobs indicated in the configuration file will be run. The various jobs types are described in :numref:`table_WS_format_info_ISC` and the filtering options are described in :numref:`wavelet_stat-configuration-file`.
+In the usage statement for the Stat-Analysis tool, some additional terminology is introduced. In the Stat-Analysis tool, the term "job" refers to a set of tasks to be performed after applying user-specified options (i.e., "filters"). The filters are used to pare down a collection of output from the MET statistics tools to only those lines that are desired for the analysis. The job and its filters together comprise the "job command line". The "job command line" may be specified either on the command line to run a single analysis job or within the configuration file to run multiple analysis jobs at the same time. If jobs are specified in both the configuration file and the command line, only the jobs indicated in the configuration file will be run. The various jobs types are described in :numref:`Des_components_STAT_analysis_tool` and the filtering options are described in :numref:`stat_analysis-configuration-file`.
 
 Required arguments for stat_analysis
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

docs/conf.py

@@ -20,12 +20,12 @@
 project = 'MET'
 author = 'UCAR/NCAR, NOAA, CSU/CIRA, and CU/CIRES'
 author_list = 'Opatz, J., T. Jensen, J. Prestopnik, H. Soh, L. Goodrich, B. Brown, R. Bullock, J. Halley Gotway, K. Newman'
-version = '11.0.2'
+version = '11.0.3'
 verinfo = version
 release = f'{version}'
 release_year = '2023'
 
-release_date = f'{release_year}-03-31'
+release_date = f'{release_year}-09-08'
 copyright = f'{release_year}, {author}'
 
 # -- General configuration ---------------------------------------------------

internal/scripts/installation/compile_MET_all.sh

@@ -214,6 +214,7 @@ fi
 COMPILER_FAMILY=` echo $COMPILER | cut -d'_' -f1`
 COMPILER_VERSION=`echo $COMPILER | cut -d'_' -f2`
 COMPILER_MAJOR_VERSION=`echo $COMPILER_VERSION | cut -d'.' -f1`
+COMPILER_MINOR_VERSION=`echo $COMPILER_VERSION | cut -d'.' -f2`
 
 echo
 echo "USE_MODULES = ${USE_MODULES}"
@@ -314,6 +315,16 @@ echo "export F77=${F77}"
 echo "export F90=${F90}"
 echo
 
+# Figure out what kind of OS is being used                                                                                                                                  
+unameOut="$(uname -s)"
+case "${unameOut}" in
+    Linux*)     machine=Linux;;
+    Darwin*)    machine=Mac;;
+    CYGWIN*)    machine=Cygwin;;
+    MINGW*)     machine=MinGw;;
+    *)          machine="UNKNOWN:${unameOut}"
+esac
+
 # Load Python module
 
 if [ ${USE_MODULES} = "TRUE" ]; then
@@ -631,7 +642,7 @@ if [ $COMPILE_NETCDF -eq 1 ]; then
   tar -xzf ${TAR_DIR}/hdf5*.tar.gz
   cd hdf5*
   echo "cd `pwd`"
-  echo "./configure --prefix=${LIB_DIR} --with-zlib=${LIB_Z} CFLAGS=-fPIC CXXFLAGS=-fPIC FFLAGS=-fPIC LDFLAGS=-L${LIB_DIR}/lib CPPFLAGS=-I${LIB_DIR}/include > configure.log 2>&1"
+  echo "./configure --prefix=${LIB_DIR} --with-zlib=${LIB_Z} CFLAGS=-fPIC CXXFLAGS=-fPIC FFLAGS=-fPIC LDFLAGS=-L${LIB_DIR}/lib:${LIB_Z} CPPFLAGS=-I${LIB_DIR}/include > configure.log 2>&1"
   ./configure --prefix=${LIB_DIR} --with-zlib=${LIB_Z} CFLAGS=-fPIC CXXFLAGS=-fPIC FFLAGS=-fPIC LDFLAGS=-L${LIB_DIR}/lib:${LIB_Z} CPPFLAGS=-I${LIB_DIR}/include > configure.log 2>&1
   ret=$?
   if [ $ret != 0 ]; then
@@ -676,8 +687,13 @@ if [ $COMPILE_NETCDF -eq 1 ]; then
   tar -xzf ${TAR_DIR}/netcdf-cxx*.tar.gz
   cd netcdf-cxx*
   echo "cd `pwd`"
-  echo "./configure --prefix=${LIB_DIR} LDFLAGS=-L${LIB_DIR}/lib CPPFLAGS=-I${LIB_DIR}/include > configure.log 2>&1"
-  ./configure --prefix=${LIB_DIR} LDFLAGS=-L${LIB_DIR}/lib CPPFLAGS=-I${LIB_DIR}/include > configure.log 2>&1
+  if [[ $machine == "Mac" ]]; then
+    echo "./configure --prefix=${LIB_DIR} LDFLAGS=-L${LIB_DIR}/lib CPPFLAGS=-I${LIB_DIR}/include LIBS=\"${LIBS} -lhdf5_hl -lhdf5 -lz\"> configure.log 2>&1"
+    ./configure --prefix=${LIB_DIR} LDFLAGS=-L${LIB_DIR}/lib CPPFLAGS=-I${LIB_DIR}/include LIBS="${LIBS} -lhdf5_hl -lhdf5 -lz"> configure.log 2>&1
+  else
+    echo "./configure --prefix=${LIB_DIR} LDFLAGS=-L${LIB_DIR}/lib CPPFLAGS=-I${LIB_DIR}/include > configure.log 2>&1"
+    ./configure --prefix=${LIB_DIR} LDFLAGS=-L${LIB_DIR}/lib CPPFLAGS=-I${LIB_DIR}/include > configure.log 2>&1
+  fi
   ret=$?
   if [ $ret != 0 ]; then
     echo "configure returned with non-zero ($ret) status"
@@ -837,6 +853,12 @@ if [ $COMPILE_MET -eq 1 ]; then
   export MET_PYTHON_LD=${MET_PYTHON_LD}
   export MET_PYTHON_CC=${MET_PYTHON_CC}
   export LDFLAGS="-Wl,--disable-new-dtags"
+
+
+  if [[ $machine == "Mac" ]]; then
+    export LDFLAGS=""
+  fi
+
   # https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html
   # ${parameter:+word}
   # If parameter is null or unset, nothing is substituted, otherwise the expansion of word is substituted.

internal/scripts/installation/config/install_met_env.hera

@@ -1,17 +1,17 @@
 module use -a /contrib/anaconda/modulefiles
 module load intel/2022.1.2
 module load anaconda/latest 
-export TEST_BASE=/contrib/met/11.0.0
+export TEST_BASE=/contrib/met/11.0.1
 export COMPILER=intel_2022.1.2
 export MET_SUBDIR=${TEST_BASE}
-export MET_TARBALL=v11.0.0.tar.gz
+export MET_TARBALL=v11.0.1.tar.gz
 export USE_MODULES=TRUE
 export PYTHON_MODULE=anaconda_latest
 export MET_PYTHON=/contrib/anaconda/anaconda3/latest/
 export MET_PYTHON_CC=-I${MET_PYTHON}/include/python3.7m
 export MET_PYTHON_LD=-L${MET_PYTHON}/lib/python3.7/config-3.7m-x86_64-linux-gnu\ -L${MET_PYTHON}/lib\ -lpython3.7m\ -lcrypt\ -lpthread\ -ldl\ -lutil\ -lrt\ -lm\ -Xlinker\ -export-dynamic
 export SET_D64BIT=FALSE
-export EXTERNAL_LIBS=/contrib/met/11.0.0/external_libs/
+export EXTERNAL_LIBS=/contrib/met/11.0.1/external_libs/
 #export MET_NETCDF=${EXTERNAL_LIBS}
 export MET_GSL=${EXTERNAL_LIBS}
 export MET_BUFRLIB=${EXTERNAL_LIBS}

internal/scripts/installation/config/install_met_env.jet

@@ -2,17 +2,17 @@ module load intel/2022.1.2
 module load netcdf/4.7.0
 module load hdf5/1.10.5
 
-export TEST_BASE=/contrib/met/11.0.0
+export TEST_BASE=/contrib/met/11.0.1
 export COMPILER=intel_18.0.5.274
 export MET_SUBDIR=${TEST_BASE}
-export MET_TARBALL=v11.0.0.tar.gz
+export MET_TARBALL=v11.0.1.tar.gz
 export USE_MODULES=TRUE
 export MET_PYTHON=/mnt/lfs1/HFIP/dtc-hurr/METplus/miniconda/miniconda3/envs/metplus_v5.0_py3.8
 export MET_PYTHON_CC=-I${MET_PYTHON}/include/python3.8
 export MET_PYTHON_LD=-L${MET_PYTHON}/lib\ -L${MET_PYTHON}/lib/python3.8/config-3.8-x86_64-linux-gnu\ -lpython3.8\ -lpthread\ -ldl\ -lutil\ -lrt\ -lm\ -Xlinker\ -export-dynamic
 export MET_NETCDF=/apps/netcdf/4.7.0/intel/18.0.5.274
 export MET_HDF5=/apps/hdf5/1.10.5/intel/18.0.5.274
-export EXTERNAL_LIBS=/contrib/met/11.0.0/external_libs/
+export EXTERNAL_LIBS=/contrib/met/11.0.1/external_libs/
 #export MET_GSL=${EXTERNAL_LIBS}
 #export MET_BUFRLIB=${EXTERNAL_LIBS}
 #export BUFRLIB_NAME=-lbufr

internal/scripts/installation/config/install_met_env.narya

@@ -0,0 +1,26 @@
+export TEST_BASE=/Volumes/d1/jpresto/projects/MET/MET_installation/11.0.2
+export COMPILER=gnu_12.3.0
+export MET_SUBDIR=${TEST_BASE}
+export MET_TARBALL=v11.0.2.tar.gz
+export USE_MODULES=FALSE
+export MET_PYTHON=/opt/local
+export MET_PYTHON_CC=-I${MET_PYTHON}/Library/Frameworks/Python.framework/Versions/3.10/include/python3.10
+export MET_PYTHON_LD=`python3-config --ldflags --embed`
+export SET_D64BIT=FALSE
+export CFLAGS="-Wall -g"
+export CXXFLAGS="-Wall -g"
+
+# If you've already compiled these and don't need to compile them again, set the following; 
+# Otherwise, if you do need to install these libraries, comment out the variables below
+export EXTERNAL_LIBS=${TEST_BASE}/external_libs
+#export MET_GRIB2CLIB=${EXTERNAL_LIBS}/lib
+#export MET_GRIB2CINC=${EXTERNAL_LIBS}/include
+#export GRIB2CLIB_NAME=-lgrib2c
+#export MET_BUFRLIB=${EXTERNAL_LIBS}/lib
+#export BUFRLIB_NAME=-lbufr
+#export MET_NETCDF=${EXTERNAL_LIBS}
+#export MET_HDF5=${EXTERNAL_LIBS}
+#export MET_GSL=${EXTERNAL_LIBS}
+#export LIB_JASPER=${EXTERNAL_LIBS}/lib
+#export LIB_LIBPNG=${EXTERNAL_LIBS}/lib
+#export LIB_Z=${EXTERNAL_LIBS}/lib

internal/scripts/installation/config/install_met_env.orion

@@ -1,14 +1,14 @@
 module load intel/2020.2
 
-export TEST_BASE=/apps/contrib/MET/11.0.0
+export TEST_BASE=/apps/contrib/MET/11.0.1
 export COMPILER=intel_2020
 export MET_SUBDIR=${TEST_BASE}/
-export MET_TARBALL=v11.0.0.tar.gz
+export MET_TARBALL=v11.0.1.tar.gz
 export USE_MODULES=TRUE
 export MET_PYTHON=/work/noaa/ovp/miniconda/miniconda3/envs/metplus_v5.0_py3.8
 export MET_PYTHON_CC=-I${MET_PYTHON}/include/python3.8
 export MET_PYTHON_LD=-L${MET_PYTHON}/lib/python3.8/config-3.8-x86_64-linux-gnu\ -L${MET_PYTHON}/lib\ -lpython3.8\ -lcrypt\ -lpthread\ -ldl\ -lutil\ -lrt\ -lm
-export EXTERNAL_LIBS=/apps/contrib/MET/11.0.0/external_libs
+export EXTERNAL_LIBS=/apps/contrib/MET/11.0.1/external_libs
 export LIB_Z=${EXTERNAL_LIBS}/lib
 #export MET_GSL=${EXTERNAL_LIBS}
 #export MET_BUFRLIB=${EXTERNAL_LIBS}