Feature #2545 interest_bounds

[JohnHalleyGotway]

Expected Differences

Add bound checking for the points of the MODE interest functions and update the docs.

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  
  Manually tested with piecewise linear interest functions with points outside the range of 0 and 1, and triggered this type of error message:

ERROR  : 
ERROR  : ModeConfInfo::parse_interest_function() -> all "angle_diff" interest function points (90, -1) must be in the range of 0 and 1.
ERROR  : 

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

• @davidalbo please review the code changes.

• @j-opatz please review the documentation updates and confirm that all the GHA tests run without error or diffs.

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

• Do these changes include sufficient testing updates? [Yes]
  I did not modify the unit tests in any way. We do not have tests to demonstrate expected failures which would be needed to test this change.

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Fri 5/19/23].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development issue with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[davidalbo]

The source code changes make sense and solve the problem. I approve the pull request.

[davidalbo]

The source code changes make sense and solve the problem. I approve the pull request.

[j-opatz]

Documentation changes clear up the limitations of the interest function entries, and clearly state the new boundaries of 0 and 1. All automated testing by GHA passed, so this PR is approved.