-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 2146 dropdown menus #2459
Conversation
…wn menus will work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The collapsible menus provide a much needed cleanup to the lengthy release notes for each Beta and official release.
The discussion made during a MET engineering meeting on the bugfix releases is still a valid concern: all of the issues would fall under a single accordion, which only perpetuates the "out of sight, out of mind" fix that doesn't fix anything at all.
As future bugfix, betas, and eventually official releases utilize this new menu layout, the METplus team needs to begin thinking about presentation of the issues in the layout to maximize usability and ease of reading. This may mean creating new top level categories, subcategories, bold font choices, or even different templates for what type of release it is. Feedback from the focus group will help, but innovative ideas can also come from within the team (as evident in the creation of this layout).
The PR does what it set out to do, and is approved.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
I have created all of the dropdown menus, open and closed them.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please test the dropdown menus by clicking on them in the feature branch before merging. https://met.readthedocs.io/en/feature_2146_dropdown_menus/Users_Guide/release-notes.html
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by 2/28/23.
I chose this date to get this change in with the beta1 release. The date can be changed.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes