Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2357 wind #2358

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Feature #2357 wind #2358

merged 1 commit into from
Nov 29, 2022

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Nov 28, 2022

Expected Differences

Adds a sanity check to ensure that the same field is identified by at most one of U-wind, V-wind, wind speed, and wind direction. This helps avoid mis-configurations as seen in dtcenter/METplus#1970.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Configured/ran Grid-Stat locally to trigger the error message.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    • Log on to seneca and runas met_test
    • Go to cd /d1/projects/MET/MET_pull_requests/met-11.0.0/met-11.0.0-rc1/feature_2357/MET
    • Modify scripts/config/GridStatConfig_all by editing the UGRD and VGRD field array entries to add:
      is_u_wind = TRUE; and is_v_wind = TRUE;.
    • Run make test and see the error message:
ERROR  : 
ERROR  : VarInfo::set_dict() -> At most one wind attribute flag (is_u_wind, is_v_wind, is_wind_speed, is_wind_direction) can be set to true for each field.
ERROR  :
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
    No doc updates needed.

  • Do these changes include sufficient testing updates? [No]
    No testing updates needed.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Wed 11/30/22].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.0 milestone Nov 28, 2022
@JohnHalleyGotway JohnHalleyGotway requested review from CPKalb and removed request for georgemccabe November 28, 2022 23:38
Copy link
Contributor

@CPKalb CPKalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected

@JohnHalleyGotway JohnHalleyGotway merged commit 9ca4a51 into develop Nov 29, 2022
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2357_wind branch November 29, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add sanity check to error out when both is_u_wind and is_v_wind are set to true
2 participants