Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
Adds a sanity check to ensure that the same field is identified by at most one of U-wind, V-wind, wind speed, and wind direction. This helps avoid mis-configurations as seen in dtcenter/METplus#1970.
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Configured/ran Grid-Stat locally to trigger the error message.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
runas met_test
cd /d1/projects/MET/MET_pull_requests/met-11.0.0/met-11.0.0-rc1/feature_2357/MET
scripts/config/GridStatConfig_all
by editing the UGRD and VGRD field array entries to add:is_u_wind = TRUE;
andis_v_wind = TRUE;
.make test
and see the error message:Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
No doc updates needed.
Do these changes include sufficient testing updates? [No]
No testing updates needed.
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Wed 11/30/22].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes