Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update develop-ref after hotfix to develop #2352

Merged
merged 523 commits into from
Nov 18, 2022
Merged

Conversation

JohnHalleyGotway
Copy link
Collaborator

Expected Differences

This hotfix to the develop branch caused the following differences in the NB output that are intended and expected.

For SHIPS_DIAG_RT, the TCDIAG line type TRACK_SOURCE column is changed from OFCL to SHIPS_TRK.

This difference is flagged in 2 files.

file1: MET-develop-ref/test_output/tc_pairs/al092022_20220926_DIAGNOSTICS.tcst
file2: MET-develop/test_output/tc_pairs/al092022_20220926_DIAGNOSTICS.tcst
ERROR: found    80 differences in row type TCST_TCDIAG#44 column TRACK_SOURCE  - max abs: 1 
ERROR: failed tests for TCST_TCDIAG#44: num
--
file1: MET-develop-ref/test_output/tc_stat/DIAGNOSTICS_filter_match_points.tcst
file2: MET-develop/test_output/tc_stat/DIAGNOSTICS_filter_match_points.tcst
ERROR: found    80 differences in row type TCST_TCDIAG#44 column TRACK_SOURCE  - max abs: 1 
ERROR: failed tests for TCST_TCDIAG#44: num

Update develop-ref to get past these diffs.

Howard Soh and others added 30 commits June 21, 2022 08:38
…narqube_python2

dtcenter/METplus-Internal#16 Moved from scripts/sonarqube to internal…
…le_factor

Bugfix #2187 develop add_offset_and_scale_factor
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
The failure from the configure script is caused by the version of the "alocal" executable.
The contents of develop are based on seneca, which has:
  aclocal (GNU automake) 1.16.1
By comparison, my laptop does NOT require that bootstrap be run for:
  aclocal (GNU automake) 1.16.5
But the Docker image has an older version which triggers the error:
  aclocal (GNU automake) 1.13.4

Any machine with aclocal 1.16.x works fine. Likely any machine with a version that differs from 1.16.x does not. Running bootstrap fixes that... but also changes the contents of all the Makefile.in files making them appear as a large set of diffs in the repo. This is not an issue inside the docker image since we generally remove the source code after compiling anyway.
…ted existing entries, removed old entries, added new entries. SL (#2199)

Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
Howard Soh and others added 28 commits November 16, 2022 11:46
Co-authored-by: Jonathan Vigh <jvigh@ucar.edu>
…tnc2ascii.py for printing an ASCII representation of the MET point observation NetCDF files.
…tcenter/MET into feature_2085_R_to_python_pntnc2ascii_R
…tcenter/MET into feature_2085_R_to_python_pntnc2ascii_R
…tcenter/MET into feature_2085_R_to_python_pntnc2ascii_R
…tcenter/MET into feature_2085_R_to_python_pntnc2ascii_R
…tcenter/MET into feature_2085_R_to_python_pntnc2ascii_R
…2ascii_R

Feature 2085 convert R script (pntnc2ascii.r) to python
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.0.0 milestone Nov 18, 2022
@JohnHalleyGotway JohnHalleyGotway merged commit 4673e35 into develop-ref Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.