Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #2102 main_v10.0 initialize modified_hdr_typ #2103

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Mar 17, 2022

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:
/d1/personal/hsoh/git/bugfixes/bugfix_2102_main_ioda2nc_header_type/MET/met/bin/ioda2nc /d1/projects/MET/MET_test_data/unit_test/obs_data/ioda/odb_sonde_16019.nc4 odb_sonde_16019_all.nc -v 3

ncdump -v hdr_typ_table odb_sonde_16019_all.nc | tail

The output should be

data:

 hdr_typ_table =
  "" ;
}
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Check the output of ioda2nc/odb_sonde_16019_all.nc

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

The garbage at the hdr_typ_table should be removed

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u requested a review from sethlinden March 17, 2022 23:17
@hsoh-u hsoh-u linked an issue Mar 22, 2022 that may be closed by this pull request
22 tasks
@hsoh-u hsoh-u requested a review from JohnHalleyGotway March 23, 2022 22:10
@JohnHalleyGotway JohnHalleyGotway changed the title #2102 Initialize modified_hdr_typ Bugfix #2102 main_v10.0 initialize modified_hdr_typ Mar 28, 2022
@JohnHalleyGotway JohnHalleyGotway removed the request for review from sethlinden March 28, 2022 17:09
@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.0.2 (bugfix) milestone Mar 28, 2022
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this fix. Recommend removing the dummy_for_action file. And we do need a 3rd PR to fix this bug in main_v10.1 as well. I checked and see that modified_hdr_typ remains uninitialized there as well.

@hsoh-u hsoh-u merged commit 4766212 into main_v10.0 Mar 28, 2022
@hsoh-u hsoh-u deleted the bugfix_2102_main_ioda2nc_header_type branch March 28, 2022 17:55
JohnHalleyGotway added a commit that referenced this pull request Mar 30, 2022
Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu>
Co-authored-by: bikegeek <minnawin@ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: bikegeek <3753118+bikegeek@users.noreply.github.com>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: hsoh-u <hsoh@ucar.edu>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix regression test differences in pb2nc and ioda2nc output
2 participants