Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update develop-ref after #2075 #2076

Merged
merged 175 commits into from
Mar 2, 2022
Merged

Update develop-ref after #2075 #2076

merged 175 commits into from
Mar 2, 2022

Conversation

JohnHalleyGotway
Copy link
Collaborator

Expected Differences

PR #2075 for issue #1918 slightly modifies the output for 2 existing Gen-Ens-Prod runs and adds a new Gen-Ens-Prod output file. These 3 diffs are flagged by the GHA testing workflow. This PR updates develop-ref to get past these differences.

New file:

ERROR: folder /data/output/met_test_truth missing 1 files
    gen_ens_prod/gen_ens_prod_CLIMO_ANOM_ENS_MEMBER_ID.nc 

Modified output, changing the model name from the default value of "WRF" to the more accurate "CFSv2":

# # # # # # # # # # # # # # # # # # # # # # # # # # # # # #

COMPARING gen_ens_prod/gen_ens_prod_SINGLE_FILE_NC_NO_CTRL.nc
file1: /data/output/met_test_truth/gen_ens_prod/gen_ens_prod_SINGLE_FILE_NC_NO_CTRL.nc
file2: /data/output/met_test_output/gen_ens_prod/gen_ens_prod_SINGLE_FILE_NC_NO_CTRL.nc
ERROR: NetCDF headers differ:
119c119
< 		:model = "WRF" ;
---
> 		:model = "CFSv2" ;

# # # # # # # # # # # # # # # # # # # # # # # # # # # # # #

COMPARING gen_ens_prod/gen_ens_prod_SINGLE_FILE_NC_WITH_CTRL.nc
file1: /data/output/met_test_truth/gen_ens_prod/gen_ens_prod_SINGLE_FILE_NC_WITH_CTRL.nc
file2: /data/output/met_test_output/gen_ens_prod/gen_ens_prod_SINGLE_FILE_NC_WITH_CTRL.nc
ERROR: NetCDF headers differ:
119c119
< 		:model = "WRF" ;
---
> 		:model = "CFSv2" ;

jprestop and others added 30 commits October 26, 2021 13:08
…tead of only the filename so that the function can tell whether or not the file exists. (#1952)

Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
* Per issue #1761 in set_perc() adding code to get FBIAS numeric value, like 1.0 or 0.9, etc. SL

* Per issue #1761: in set_perc(), modified actual percentile calculation at end to use the extracted FBIAS numeric value (float). SL

* Per issue #1761: modified the check on the perc_thresh_freq_bias, just has to be > 0 now. SL

* Per issue #1761: cleaned up code in set_perc(). SL

* Per #1761, updates to Simple_Node::set_perc() to handle variable frequency bias amounts.
Changes include:
- Reverting the formatting of this back to how it originally was in the develop branch. In general, just match the formatting of the existing file, so as the minimize the number of difference lines.
- Add logic to adjust the percentile to be found based on the requested FBIAS value. Multiplying or dividing the percentile by the FBIAS value depends on the inequality type and whether we're bias adjusting the forecast or observation data.
- Adjust the log messages slightly.

Please be aware that I'm not totally confident in these changes. They warrant much more testing. This logic is very, very confusing.

* Per #1761, call compute_percentile() when double-checking the percentile values.

* Per #1761, remove unused variable.

* Per #1761, add warning for percentiles > 100.

* Per #1761. In set_perc(), after testing cleaned up code. SL

* Per issue #1761: adding new config file for testing dynamic FBIAS values. SL

* Per issue #1761: added new unit test for dynamic FBIAS values when running grid_stat. SL

* Per issue #1761, modified FBIAS section to indicated that the user can use dynamic values that are not 1.0. SL

* Update met/docs/Users_Guide/config_options.rst

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update met/docs/Users_Guide/config_options.rst

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update met/docs/Users_Guide/config_options.rst

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <johnhg@ucar.edu>

* Per issue #1761, set nc_pairs_flag = FALSE. SL

Co-authored-by: Seth Linden <linden@kiowa.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
…ing the logic for computing the ensemble range back to what it was previously. The new version produced very slight differences in the 6-th or 7-th decimal place when compared to previous results. There's not good reason for these changes which were caused by the order of operations in casting from doubles to floats. Reverting back to the old logic prevents diffs for anyone else downstream and is the prudent choice.
* #1949 Added CF compliant NetCDF into data IO

* #1949 Added commas

* #1948 Some corrections for typo and added the links for CF attributes

* #1948 Added Performance with NetCDF input data

* #1949 Corrected tyoe and applied Juloie's suggestions

Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu>
…OSS. The intel compiler does not allow adjacent >> characters when defining maps.
hsoh-u and others added 25 commits February 18, 2022 16:31
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
#1824 ci-run-test Reset itype to 1 for regular CAPE
* found and made three changes replacing met_help@ucar.edu with the MetPlus gitub discussions page

* Update met/docs/Users_Guide/appendixA.rst

Thanks, a typo plus I am completely neutral as to the exact wording.

Co-authored-by: jprestop <jpresto@ucar.edu>

* Update met/src/libcode/vx_data2d_grib2/data2d_grib2.cc

Co-authored-by: jprestop <jpresto@ucar.edu>

* Update met/README

Co-authored-by: jprestop <jpresto@ucar.edu>

Co-authored-by: jprestop <jpresto@ucar.edu>
* Updated set_job_controls.sh to add a check for the skip all keyword

* Added a space to check keyword ci-skip-all

Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
* Per #1918, store the ensemble_member_id string in the EnsVarInfo class so that we can use it later, if needed, when reading climatological data which may also make use of that string.

* Per #1918, update gen_ens_prod to set the MET_ENS_MEMBER_ID environment variable when reading climatology data if the ens_member_ids config option has been set and the normalizing relative to climatology has been requested.

* Per #1918, add log messages to read_climo.cc and gen_ens_prod.cc to clarify what data is being read from which climo data files.

* Added documentation on MET_ENS_MEMBER_ID usage in climo file name

* updated usage langauge

* Per #1918, adding gen_ens_prod unit test to demonstrate using ENS_MEMBER_ID to read climo data separately for each member.

* Per #1918, adding gen_ens_prod unit test to demonstrate using ENS_MEMBER_ID to read climo data separately for each member.

Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.1.0 milestone Mar 2, 2022
@JohnHalleyGotway JohnHalleyGotway merged commit 49a6050 into develop-ref Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Gen-Ens-Prod to standardize ensemble members relative to climatology.
8 participants