Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update develop-ref after #1835. #1846

Merged
merged 8 commits into from
Jul 6, 2021
Merged

Update develop-ref after #1835. #1846

merged 8 commits into from
Jul 6, 2021

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Jul 6, 2021

Pull Request Testing

Update develop-ref after PR #1835 for issue #1817. This bugfix corrects point2grid output which modifies/corrects output in produced by the unit tests in the develop branch.

  • Describe testing already performed for these changes:

    The NB for develop failed on 20210706 with the modified output.
    kiowa:/d1/projects/MET/MET_regression/develop/NB20210706/test_regression_20210706.log
COMPARING point2grid/point2grid_2D_time_west_bering_sea.nc
file1: MET-develop-ref/test_output/point2grid/point2grid_2D_time_west_bering_sea.nc
file2: MET-develop/test_output/point2grid/point2grid_2D_time_west_bering_sea.nc
ERROR: found  5421 differences in var brightness_temperature_4micron         - max abs: 26.39667 
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    No additional testing needed.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
    This PR serves as documentation of the change.

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

    As described above.

  • Please complete this pull request review by [07/06/21].

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.1.0 milestone Jul 6, 2021
@JohnHalleyGotway JohnHalleyGotway requested a review from jprestop July 6, 2021 15:50
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this PR serves as documentation of the change and that no additional testing is necessary. I approve this request.

@JohnHalleyGotway JohnHalleyGotway merged commit 7b3fa26 into develop-ref Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The output of point2grid is flipped and rotated with lat/lon to lat/lon conversion
3 participants