Per #2506, first batch of commits to resolve SonarQube 'will never be…

… executed' bugs classified as major.

src/basic/enum_to_string/enum_to_string.cc

@@ -386,8 +386,6 @@ if ( debug )  {
 
 exit ( 1 );
 
-return;
-
 }
 
 

src/basic/vx_config/config.tab.cc

@@ -2268,8 +2268,6 @@ mlog << Error
 
 exit ( 1 );
 
-return;
-
 }
 
 
@@ -2320,8 +2318,6 @@ switch ( op )  {
    default:
       cerr << "\n\n  do_op() -> unrecognized op ... \"" << op << "\"\n\n";
       exit ( 1 );
-      break;
-
 
 }   //  switch
 
@@ -2371,7 +2367,6 @@ switch ( op )  {
       mlog << Error << "\ndo_integer_op() -> "
            << "bad operator ... \"" << op << "\"\n\n";
       exit ( 1 );
-      break;
 
 }
 

src/basic/vx_config/config.tab.yy

@@ -476,8 +476,6 @@ mlog << Error
 
 exit ( 1 );
 
-return;
-
 }
 
 
@@ -528,8 +526,6 @@ switch ( op )  {
    default:
       cerr << "\n\n  do_op() -> unrecognized op ... \"" << op << "\"\n\n";
       exit ( 1 );
-      break;
-
 
 }   //  switch
 
@@ -579,7 +575,6 @@ switch ( op )  {
       mlog << Error << "\ndo_integer_op() -> "
            << "bad operator ... \"" << op << "\"\n\n";
       exit ( 1 );
-      break;
 
 }
 

src/basic/vx_config/dictionary.cc

@@ -2417,18 +2417,12 @@ DictionaryStack & DictionaryStack::operator=(const DictionaryStack & s)
 
 {
 
-// if ( this == &s )  return ( * this );
-//
-// assign(s);
-
 mlog << Error
      << "\nDictionaryStack::operator=(const DictionaryStack &) -> "
      << "should never be called!\n\n";
 
 exit ( 1 );
 
-return ( * this );
-
 }
 
 

src/basic/vx_log/logger.cc

@@ -421,8 +421,6 @@ Logger & Logger::operator=(const Logger & l)
    cerr << "\n\n  operator=(const Logger & l) -> This function should never be called\n\n";
    exit (1);
 
-   return (*this);  // left in to keep the compiler quiet
-
 }
 
 

src/basic/vx_math/pwl.cc

@@ -308,8 +308,6 @@ mlog << Error << "\nPiecewiseLinear::operator()(double) -> error in \""
 
 exit ( 1 );
 
-return ( -100 );   //  just to satisfy the compiler
-
 }
 
 

src/basic/vx_util/command_line.cc

@@ -847,11 +847,8 @@ else {
 
 }
 
-
 exit ( 1 );
 
-return;
-
 }
 
 
@@ -893,8 +890,6 @@ cout << "\n";
 
 exit ( 1 );
 
-return;
-
 }
 
 

src/basic/vx_util/data_line.cc

@@ -649,9 +649,6 @@ mlog << Error << "\nLineDataFile::operator=(const LineDataFile &) -> "
 
 exit ( 1 );
 
-
-return ( * this );
-
 }
 
 

src/basic/vx_util/memory.cc

@@ -26,7 +26,6 @@ void oom() {
    mlog << Error << "\nOut of memory!  Exiting!\n\n";
    exit(1);
 
-   return;
 }
 
 ////////////////////////////////////////////////////////////////////////
@@ -39,7 +38,6 @@ void oom_grib2() {
         << "flag.\n\n";
    exit(1);
 
-   return;
 }
 
 ////////////////////////////////////////////////////////////////////////

src/basic/vx_util/python_line.cc

@@ -344,8 +344,6 @@ if ( PyErr_Occurred() )  {
 
    exit ( 1 );
 
-   return;
-
 }
 
    //

src/libcode/vx_bool_calc/bool_calc.cc

@@ -186,7 +186,6 @@ for (j=0; j<((int) P.size()); ++j)  {
               << "bad token in program ... \n\n";
          tok.dump(cerr, 1);
          exit ( 1 );
-         break;
 
    }   //  switch
 

src/libcode/vx_color/color_parser_yacc.cc

@@ -2226,8 +2226,6 @@ cout.flush();
 
 exit ( 1 );
 
-return;
-
 }
 
 

src/libcode/vx_color/color_parser_yacc.yy

@@ -729,8 +729,6 @@ cout.flush();
 
 exit ( 1 );
 
-return;
-
 }
 
 

src/libcode/vx_color/color_table.cc

@@ -536,8 +536,6 @@ mlog << Error << "\nColorTable::interp(double) const -> confused!\n\n";
 
 exit ( 1 );
 
-return ( black );
-
 }
 
 

src/libcode/vx_data2d_grib/data2d_grib.cc

@@ -78,10 +78,6 @@ mlog << Error << "\nMetGrib1DataFile::MetGrib1DataFile(const MetGrib1DataFile &)
 
 exit ( 1 );
 
-// grib1_init_from_scratch();
-//
-// assign(f);
-
 }
 
 
@@ -97,12 +93,6 @@ mlog << Error << "\nMetGrib1DataFile::operator=(const MetGrib1DataFile &) -> "
 
 exit ( 1 );
 
-// if ( this == &f )  return ( * this );
-//
-// assign(f);
-
-return ( * this );
-
 }
 
 
@@ -160,8 +150,6 @@ if ( ! (GF->open(_filename)) )  {
    mlog << Error << "\nMetGrib1DataFile::open(const char *) -> "
         << "unable to open grib1 file \"" << _filename << "\"\n\n";
 
-   // exit ( 1 );
-
    close();
 
    return ( false );
@@ -343,8 +331,6 @@ if ( !GF )  {
    mlog << Error << "\nMetGrib1DataFile::read_record(const VarInfoGrib &) -> "
         << "no grib file open!\n\n";
 
-   // exit ( 1 );
-
    return ( -1 );
 
 }
@@ -363,8 +349,6 @@ for (j=0; j<(GF->n_records()); ++j)  {
 
       mlog << Error << "\nMetGrib1DataFile::read_record(const VarInfoGrib &) -> trouble reading record!\n\n";
 
-      // exit ( 1 );
-
       return ( -1 );
 
    }
@@ -404,8 +388,6 @@ if ( j_match >= 0 )  {
       mlog << Error << "\nMetGrib1DataFile::read_record(const VarInfoGrib &) -> "
            << "trouble reading record!\n\n";
 
-      // exit ( 1 );
-
       return ( -1 );
 
    }