Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power rankings need to be manually updated each week #1

Closed
dtcarls opened this issue Sep 19, 2017 · 4 comments
Closed

Power rankings need to be manually updated each week #1

dtcarls opened this issue Sep 19, 2017 · 4 comments
Assignees

Comments

@dtcarls
Copy link
Owner

dtcarls commented Sep 19, 2017

Power rankings need to be manually updated each week until rbarton65/espnff#31 is resolved and rbarton65/espnff#32 is accepted

@dtcarls dtcarls self-assigned this Sep 20, 2017
@dtcarls
Copy link
Owner Author

dtcarls commented Sep 21, 2017

Good conversation going on here linked so I don't lose it. a82b10b#comments

@dtcarls
Copy link
Owner Author

dtcarls commented Sep 21, 2017

Continuing convo from a82b10b#comments @raulvasquez @DBaryudin

See this commit in develop branch. 82e197d
Double check my logic before I publish to master. It seems current_week-1 and not current_week should be used for power ranks after running power ranks manually with weeks 1, 2, 3, 4, 5.

I'd also like to try and bring in @cawdev since they seem to be adding a lot and I basically used their algo with a couple slight tweeks for this fix.

@OldAchilles
Copy link

The code will iterate through the scores:

  • Week 1: Count = 2
  • Week 2: Count = 3
  • Week 3: Count = 2 again, right?

@dtcarls
Copy link
Owner Author

dtcarls commented Sep 22, 2017

Should be:
Week 1: Count = 1
Week 2: Count = 1
Week 3: Count = 2
Week 4: Count = 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants