This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
Remove commands to delete empty files in export #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like a really bad idea, at least the way it's described here. In my local, fairly empty directory, `find . -type f | xargs wc -l | grep '1 .'` returns:
```
1 ./.git/COMMIT_EDITMSG
1 ./.git/description
1 ./.git/HEAD
1 ./.git/logs/HEAD
1 ./.git/logs/refs/heads/master
11 ./.git/objects/42/14eb21b7be0687ccb477ec1e5a8ecdf7711b05
1 ./.git/objects/5e/001b34698fe2cd0da484fa9ab896e42df155b9
1 ./.git/refs/heads/master
1 ./.gitignore
1 ./asg.tf
1 ./dbsg.tf
1 ./dbsn.tf
1 ./ec2.tf
1 ./ecc.tf
1 ./ecsn.tf
1 ./eip.tf
1 ./elb.tf
1 ./iamp.tf
1 ./iamrp.tf
1 ./igw.tf
1 ./lc.tf
1 ./nacl.tf
1 ./nif.tf
1 ./r53r.tf
1 ./r53z.tf
1 ./rds.tf
1 ./rs.tf
1 ./rt.tf
1 ./rta.tf
1 ./sn.tf
1 ./sqs.tf
1 ./vgw.tf
1 ./vpc.tf
```
As you can see, it is deleting _anything_ in the folder with 1 line in it. Not only that, it's deleting _anything_ with a count of lines _ending_ in 1. So 11, 21, 9991 line files would be deleted as well.
This checks that the files match `'*.tf'` and adds a space before the `1` in the grep command to fix those issues. It also removes the `xargs rm`.
|
Yes please! This just wiped out my .git folder. Stupid me, but it would be good to not make the default so destructive. 😢 |
|
Thank you for fixing! Current example is dangerous... LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a really bad idea, at least the way it's described here. In my local, fairly empty directory,
find . -type f | xargs wc -l | grep '1 .'returns:As you can see, it is deleting anything in the folder with 1 line in it. Not only that, it's deleting anything with a count of lines ending in 1. So 11, 21, 9991 line files would be deleted as well.
This checks that the files match
'*.tf'and adds a space before the1in the grep command to fix those issues. It also removes thexargs rm.