Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove mkdirp dependency #1549

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Conversation

benmccann
Copy link
Contributor

No description provided.

Copy link
Owner

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsherret dsherret changed the title chore: remove mkdirp dependency perf: remove mkdirp dependency Jun 26, 2024
Copy link
Owner

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to have introduced a regression. See CI output. We'll just have to update this code to not throw for existing directories.

@benmccann
Copy link
Contributor Author

sorry, I can't figure out how to run the project locally. I've never used Deno before and am not familiar with what's happening in the build process. I noticed an error in the code and updated it, so hopefully that will get the tests passing. If not, I may need a little help with this one

@dsherret
Copy link
Owner

I think it should just be to run npm install in the root, then cd packages/common, then npm run test

@benmccann
Copy link
Contributor Author

ah, cool. thanks. that worked! I was trying to build it from the root first, which wasn't working at all

@benmccann benmccann requested a review from dsherret June 26, 2024 21:15
@benmccann
Copy link
Contributor Author

@dsherret would you be able to give this PR another peek now that the CI is passing? thanks!

Copy link
Owner

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret merged commit 69f674d into dsherret:latest Aug 25, 2024
2 checks passed
@benmccann benmccann deleted the rm-mkdirp branch August 25, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants