Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xRDCertificateConfiguration: Prevents 'Get-RDServer'' not recognized error #98

Merged
merged 9 commits into from
Jul 14, 2022

Conversation

uw-dc
Copy link
Contributor

@uw-dc uw-dc commented Jul 14, 2022

Pull Request (PR) description

Fixes an issue that occurs in some circumstances:
'The term 'Get-RDServer' is not recognized as the name of a cmdlet'

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of file CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • N/A Resource documentation added/updated in README.md.
  • N/A Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • N/A Comment-based help added/updated.
  • N/A Localization strings added/updated in all localization files as appropriate.
  • N/A Examples appropriately added/updated.
  • N/A Unit tests added/updated. See DSC Community Testing Guidelines.
  • N/A Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

'The term 'Get-RDServer' is not recognized as the name of a cmdlet'
@uw-dc
Copy link
Contributor Author

uw-dc commented Jul 14, 2022

##[warning]An image label with the label ubuntu 16.04 does not exist.

`An image label with the label ubuntu 16.04 does not exist.`
This is an attempt to resolve `The framework 'Microsoft.NETCore.App', version '2.1.0' (x64) was not found.` in Azure pipeline (gitversion job)

https://dev.azure.com/dsccommunity/xRemoteDesktopSessionHost/_build/results?buildId=6304&view=logs&j=106e58e8-a59e-5cbd-0716-376180231163&t=cc899c23-0acc-5cd0-5295-95cfdd0edd43
@uw-dc
Copy link
Contributor Author

uw-dc commented Jul 14, 2022

GitVersion action is deprecated ... should be using GitTools instead?

GitTools/GitVersion#3073

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

We are changing to installing GitVersion with dotnet instead: https://github.com/gaelcolas/Sampler/blob/dade014db4c6109ca64f249497a3dcf0a9504283/azure-pipelines.yml#L28-L45

But your change seems to work, so we leave it as that. Another PR can change all pipeline files to the latest (from the Sampler templates).

Reviewed 2 of 2 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @uw-dc)

@johlju johlju merged commit 7f27c97 into dsccommunity:master Jul 14, 2022
@johlju
Copy link
Member

johlju commented Jul 14, 2022

The deploy fails since this repo is too far behind the current pipeline templates. I can look into it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xRDCertificateConfiguration:The term ''Get-RDServer'' is not recognized
2 participants