Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG.md: Undo version 8.5.0.0 #524

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

mhendric
Copy link
Contributor

@mhendric mhendric commented Feb 3, 2019

Pull Request (PR) description

Removes version 8.5.0.0 from CHANGELOG.md

This Pull Request (PR) fixes the following issues

None

Task list

  • Added an entry under the Unreleased section of the change log in
    CHANGELOG.md. Entry should say what was changed, and how that affects
    users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as
    appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See
    DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See
    DSC Resource Testing Guidelines.
  • New/changed code adheres to
    DSC Resource Style Guidelines
    and
    Best Practices.

This change is Reviewable

@mhendric mhendric added the needs review The pull request needs a code review. label Feb 3, 2019
@mhendric mhendric requested a review from PlagueHO February 3, 2019 19:09
@codecov-io
Copy link

Codecov Report

Merging #524 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #524   +/-   ##
===================================
  Coverage    74%    74%           
===================================
  Files        27     27           
  Lines      4031   4031           
  Branches      4      4           
===================================
  Hits       3005   3005           
  Misses     1022   1022           
  Partials      4      4

@PlagueHO
Copy link
Member

PlagueHO commented Feb 4, 2019

Done. Thanks @mhendric

Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit 2c5baef into dsccommunity:dev Feb 4, 2019
@mhendric mhendric deleted the UndoRelease branch February 7, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants