Update CommonResourceHelper, ResourceHelper, MSFT_xDSCWebService and MSFT_xDSCWebService tests to Pester 4 standards #475
Conversation
…MSFT_xDSCWebService tests to Pester 4 standards
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @PlagueHO)
Tests/Integration/MSFT_xDSCWebService.xxx.ps1, line 45 at r1 (raw file):
Name = ???DSC-Service???
Something strange happened here? Quotes was replaced by three question marks. Throughout this file.
Tests/Integration/MSFT_xDSCWebService.xxx.ps1, line 53 at r1 (raw file):
should -not -throw
Maybe Should -Not -Throw. Upper case throughout.
Tests/Integration/MSFT_xDSCWebService.xxx.ps1, line 121 at r1 (raw file):
should -be 0
should -not -throw
Maybe Should -Be-. Upper case throughout.
Tests/Unit/MSFT_xDSCWebService.Tests.ps1, line 535 at r1 (raw file):
-be
-Be. Upper case throughout.
Codecov Report
@@ Coverage Diff @@
## dev #475 +/- ##
===================================
Coverage 72% 72%
===================================
Files 27 27
Lines 4022 4022
Branches 4 4
===================================
Hits 2921 2921
Misses 1097 1097
Partials 4 4 |
There was a problem hiding this comment.
Thanks for reviewing @johlju. The integration tests for xDscWebService (the ones that are disabled) are actually pretty messed up (they could never work). I've improved them a bit but they're going to need a lot more work to make them: a) useful and b) working
No idea how they could ever get into that state - looks like they've not worked in a LONG time. Will raise an issue to fix them.
Reviewable status: 2 of 5 files reviewed, 4 unresolved discussions (waiting on @johlju)
Tests/Integration/MSFT_xDSCWebService.xxx.ps1, line 45 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Name = ???DSC-Service???Something strange happened here? Quotes was replaced by three question marks. Throughout this file.
Done.
Tests/Integration/MSFT_xDSCWebService.xxx.ps1, line 53 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
should -not -throwMaybe
Should -Not -Throw. Upper case throughout.
Done.
Tests/Integration/MSFT_xDSCWebService.xxx.ps1, line 121 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
should -be 0should -not -throwMaybe
Should -Be-. Upper case throughout.
Done.
Tests/Unit/MSFT_xDSCWebService.Tests.ps1, line 535 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
-be
-Be. Upper case throughout.
Done.
There was a problem hiding this comment.
Raised issue to correct integration tests: #476
Reviewable status: 2 of 5 files reviewed, 4 unresolved discussions (waiting on @johlju)
There was a problem hiding this comment.
Yes, this resource moudel need a lot of love - one step at a time. 😄
Reviewed 3 of 3 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
|
Thanks @johlju |
Pull Request (PR) description
This PR:
CommonResourceHelperunit tests to meet Pester 4.0.0standards (issue #473).
ResourceHelperunit tests to meet Pester 4.0.0standards (issue #473).
MSFT_xDSCWebServiceunit tests to meet Pester 4.0.0standards (issue #473).
MSFT_xDSCWebServiceintegration tests to meet Pester 4.0.0standards (issue #473).
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
@johlju would you mind reviewing when you get a moment. Should be straight forward.
This change is