-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xRemoteFile: Updating parameter description for MatchSource - Fixes #409 #410
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #410 +/- ##
===================================
Coverage 67% 67%
===================================
Files 27 27
Lines 3939 3939
Branches 4 4
===================================
Hits 2670 2670
Misses 1265 1265
Partials 4 4 |
Reviewed 1 of 1 files at r1. a discussion (no related file): README.md, line 295 at r1 (raw file):
In other locations this is written as 'The default value is true.'. Could we change to that? README.md, line 295 at r1 (raw file):
Please update the description in the schema.mof for the xRemoteFile resource as well. Comments from Reviewable |
Labeling this PR as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on the PR is taken up again. |
Hi @shurick81 . Following up on this to see if you can still finish this one up? Looks like this just needs a rebase per the below article, and an entry added to the Unreleased section saying what you did. Thanks in advance. |
Probably we just recreate the PR and close this one. |
I'm going to recreate the PR for this one. |
Fixes #409
This change is