Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xRemoteFile: Updating parameter description for MatchSource - Fixes #409 #410

Closed
wants to merge 1 commit into from

Conversation

shurick81
Copy link

@shurick81 shurick81 commented Apr 29, 2018

Fixes #409

This change is Reviewable

@codecov-io
Copy link

Codecov Report

Merging #410 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #410   +/-   ##
===================================
  Coverage    67%    67%           
===================================
  Files        27     27           
  Lines      3939   3939           
  Branches      4      4           
===================================
  Hits       2670   2670           
  Misses     1265   1265           
  Partials      4      4

@johlju
Copy link
Member

johlju commented May 1, 2018

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


a discussion (no related file):
Please add an entry for this to the Unreleased section of the chnage log in the file README.md.


README.md, line 295 at r1 (raw file):

* **Headers**: Headers of the web request. Optional.
* **Credential**: Specifies credential of a user which has permissions to send the request. Optional.
* **MatchSource**: Determines whether the remote file should be re-downloaded if file in the DestinationPath was modified locally. Optional. True by default.

In other locations this is written as 'The default value is true.'. Could we change to that?


README.md, line 295 at r1 (raw file):

* **Headers**: Headers of the web request. Optional.
* **Credential**: Specifies credential of a user which has permissions to send the request. Optional.
* **MatchSource**: Determines whether the remote file should be re-downloaded if file in the DestinationPath was modified locally. Optional. True by default.

Please update the description in the schema.mof for the xRemoteFile resource as well.


Comments from Reviewable

@johlju johlju changed the title #409, by default, xRemoteFile always returns false in test xRemoteFile: Updating parameter description for MatchSource - Fixes #409 May 1, 2018
@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label May 1, 2018
@johlju
Copy link
Member

johlju commented May 23, 2018

Labeling this PR as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on the PR is taken up again.

@johlju johlju added abandoned The pull request has been abandoned. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels May 23, 2018
@mhendric
Copy link
Contributor

Hi @shurick81 . Following up on this to see if you can still finish this one up? Looks like this just needs a rebase per the below article, and an entry added to the Unreleased section saying what you did. Thanks in advance.

https://github.com/PowerShell/DscResources/blob/master/GettingStartedWithGitHub.md#resolve-merge-conflicts

@mhendric
Copy link
Contributor

mhendric commented Feb 3, 2019

@PlagueHO and @johlju , what do you think we should do with this one?

@PlagueHO
Copy link
Member

PlagueHO commented Feb 4, 2019

Probably we just recreate the PR and close this one.

@PlagueHO
Copy link
Member

I'm going to recreate the PR for this one.

@PlagueHO PlagueHO closed this Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned The pull request has been abandoned.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants