-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean xWindowsFeatureSet, xWindowsOptionalFeatureSet, and xProcessSet and add tests #297
Conversation
Reviewed 27 of 27 files at r1. README.md, line 135 at r1 (raw file):
Just noticed that these examples for group need to be updated README.md, line 435 at r1 (raw file):
'that you want to install or uninstall.' README.md, line 438 at r1 (raw file):
'roles or features.' README.md, line 495 at r1 (raw file):
It looks like Present isn't a default here. DSCResources/xWindowsFeatureSet/xWindowsFeatureSet.schema.psm1, line 30 at r1 (raw file):
'roles or features.' Tests/Integration/xWindowsOptionalFeatureSet.Integration.Tests.ps1, line 99 at r1 (raw file):
newline before 'It' Comments from Reviewable |
Review status: all files reviewed at latest revision, 6 unresolved discussions. README.md, line 135 at r1 (raw file): Previously, mbreakey3 (Mariah) wrote…
Huh? This is xGroupSet, not xGroup. README.md, line 435 at r1 (raw file): Previously, mbreakey3 (Mariah) wrote…
Done. README.md, line 438 at r1 (raw file): Previously, mbreakey3 (Mariah) wrote…
Done. README.md, line 495 at r1 (raw file): Previously, mbreakey3 (Mariah) wrote…
Done. DSCResources/xWindowsFeatureSet/xWindowsFeatureSet.schema.psm1, line 30 at r1 (raw file): Previously, mbreakey3 (Mariah) wrote…
Done. Tests/Integration/xWindowsOptionalFeatureSet.Integration.Tests.ps1, line 99 at r1 (raw file): Previously, mbreakey3 (Mariah) wrote…
Done. Comments from Reviewable |
Reviewed 3 of 3 files at r2. README.md, line 135 at r1 (raw file): Previously, kwirkykat (Katie Keim) wrote…
nevermind Comments from Reviewable |
Cleaning the remaining Set resources for #160.
Added and updated the integration tests, documentation, and examples for these resources as well.
This change is