Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean xWindowsFeatureSet, xWindowsOptionalFeatureSet, and xProcessSet and add tests #297

Merged
merged 4 commits into from
Dec 16, 2016

Conversation

kwirkykat
Copy link
Contributor

@kwirkykat kwirkykat commented Dec 16, 2016

Cleaning the remaining Set resources for #160.
Added and updated the integration tests, documentation, and examples for these resources as well.


This change is Reviewable

@kwirkykat kwirkykat added the needs review The pull request needs a code review. label Dec 16, 2016
@kwirkykat kwirkykat requested a review from mbreakey3 December 16, 2016 01:24
@mbreakey3
Copy link
Contributor

Reviewed 27 of 27 files at r1.
Review status: all files reviewed at latest revision, 6 unresolved discussions.


README.md, line 135 at r1 (raw file):

#### Examples

* [Add members to multiple groups](https://github.com/PowerShell/xPSDesiredStateConfiguration/blob/dev/Examples/Sample_xGroupSet_AddMembers.ps1)

Just noticed that these examples for group need to be updated


README.md, line 435 at r1 (raw file):

#### Parameters

* **[String] Name** _(Key)_: The names of the roles or features that you want install or uninstall. This may be different from the display name of the feature/role. To retrieve the names of features/roles on a machine use the Get-WindowsFeature cmdlet.

'that you want to install or uninstall.'


README.md, line 438 at r1 (raw file):

* **[String] Ensure** _(Write)_: Specifies whether the feature should be installed or uninstalled. To install features, set this property to Present. To uninstall features, set this property to Absent. { Present | Absent }.
* **[Boolean] IncludeAllSubFeature** _(Write)_: Specifies whether or not all subfeatures should be installed or uninstalled alongside the specified roles or features. If this property is true and Ensure is set to Present, all subfeatures will be installed. If this property is false and Ensure is set to Present, subfeatures will not be installed or uninstalled. If Ensure is set to Absent, all subfeatures will be uninstalled.
* **[PSCredential] Credential** _(Write)_: The credential of the user account under which to install or uninstall the role or feature.

'roles or features.'


README.md, line 495 at r1 (raw file):

The following parameters will be the same for each Windows optional feature in the set:

* **[String] Ensure** _(Write)_: Specifies whether the Windows optional features should be enabled or disabled. To enable the features, set this property to Present. To disable the features, set this property to Absent. { *Present* | Absent }.

It looks like Present isn't a default here.


DSCResources/xWindowsFeatureSet/xWindowsFeatureSet.schema.psm1, line 30 at r1 (raw file):

    .PARAMETER Credential
        The credential of the user account under which to install or uninstall the role or feature.

'roles or features.'


Tests/Integration/xWindowsOptionalFeatureSet.Integration.Tests.ps1, line 99 at r1 (raw file):

            foreach ($windowsOptionalFeatureName in $wofSetParameters.WindowsOptionalFeatureNames)
            {
                $windowsOptionalFeature = Dism\Get-WindowsOptionalFeature -Online -FeatureName $windowsOptionalFeatureName

newline before 'It'


Comments from Reviewable

@kwirkykat
Copy link
Contributor Author

Review status: all files reviewed at latest revision, 6 unresolved discussions.


README.md, line 135 at r1 (raw file):

Previously, mbreakey3 (Mariah) wrote…

Just noticed that these examples for group need to be updated

Huh? This is xGroupSet, not xGroup.


README.md, line 435 at r1 (raw file):

Previously, mbreakey3 (Mariah) wrote…

'that you want to install or uninstall.'

Done.


README.md, line 438 at r1 (raw file):

Previously, mbreakey3 (Mariah) wrote…

'roles or features.'

Done.


README.md, line 495 at r1 (raw file):

Previously, mbreakey3 (Mariah) wrote…

It looks like Present isn't a default here.

Done.


DSCResources/xWindowsFeatureSet/xWindowsFeatureSet.schema.psm1, line 30 at r1 (raw file):

Previously, mbreakey3 (Mariah) wrote…

'roles or features.'

Done.


Tests/Integration/xWindowsOptionalFeatureSet.Integration.Tests.ps1, line 99 at r1 (raw file):

Previously, mbreakey3 (Mariah) wrote…

newline before 'It'

Done.


Comments from Reviewable

@mbreakey3
Copy link
Contributor

:lgtm:


Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


README.md, line 135 at r1 (raw file):

Previously, kwirkykat (Katie Keim) wrote…

Huh? This is xGroupSet, not xGroup.

nevermind


Comments from Reviewable

@kwirkykat kwirkykat merged commit 76663f5 into dsccommunity:dev Dec 16, 2016
@kwirkykat kwirkykat deleted the CleanSets2 branch December 16, 2016 03:14
@kwirkykat kwirkykat removed the needs review The pull request needs a code review. label Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants