-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xPackage fixes and updates #278
Conversation
@iainbrighton - change looks great. I didn't review using the HQRM guidelines though. Sorry about the Out-Null nit picks :) Reviewed 4 of 4 files at r1. Tests/Unit/MSFT_xPackageResource.Tests.ps1, line 38 at r1 (raw file):
Not lines that you wrote, but could you assign these two lines to $null rather than pipe to Out-Null? Comments from Reviewable |
Review status: 3 of 4 files reviewed at latest revision, 1 unresolved discussion. Tests/Unit/MSFT_xPackageResource.Tests.ps1, line 38 at r1 (raw file): Previously, PlagueHO (Daniel Scott-Raynsford) wrote…> Not lines that you wrote, but could you assign these two lines to $null rather than pipe to Out-Null?Comments from Reviewable |
piping to Reviewed 1 of 1 files at r2. Comments from Reviewable |
Please resolve all merge conflicts. For more information see GitHowTo - 30. Resolving Conflicts |
I don't see any merge conflicts? Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. Comments from Reviewable |
GitHub says readme.md has a conflict |
Reviewed 2 of 3 files at r3. Comments from Reviewable |
* xPackage fixes and updates * Replaces Out-Null with $null assignments * Resolves README.md merge conflict
xPackage:
errLogPath
and inverse conditional (minor) #224This change is