Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xPackage fixes and updates #278

Merged
merged 4 commits into from
Dec 2, 2016
Merged

Conversation

iainbrighton
Copy link
Contributor

@iainbrighton iainbrighton commented Nov 21, 2016

xPackage:


This change is Reviewable

@kwirkykat kwirkykat added the needs review The pull request needs a code review. label Nov 21, 2016
@PlagueHO
Copy link
Member

@iainbrighton - change looks great. I didn't review using the HQRM guidelines though. Sorry about the Out-Null nit picks :)


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Tests/Unit/MSFT_xPackageResource.Tests.ps1, line 38 at r1 (raw file):

                $script:testExecutablePath = Join-Path -Path $script:testDirectoryPath -ChildPath 'TestExecutable.exe'
                
                New-TestExecutable -DestinationPath $script:testExecutablePath | Out-Null

Not lines that you wrote, but could you assign these two lines to $null rather than pipe to Out-Null?


Comments from Reviewable

@iainbrighton
Copy link
Contributor Author

Review status: 3 of 4 files reviewed at latest revision, 1 unresolved discussion.


Tests/Unit/MSFT_xPackageResource.Tests.ps1, line 38 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote… > Not lines that you wrote, but could you assign these two lines to $null rather than pipe to Out-Null?
No problem. Done!

Comments from Reviewable

@TravisEz13
Copy link
Contributor

piping to $null looks cleaner to me, but LGTM


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

@TravisEz13
Copy link
Contributor

Please resolve all merge conflicts. For more information see GitHowTo - 30. Resolving Conflicts

@TravisEz13 TravisEz13 added waiting for author response The pull request is waiting for the author to respond to comments in the pull request. and removed needs review The pull request needs a code review. labels Nov 29, 2016
@iainbrighton
Copy link
Contributor Author

I don't see any merge conflicts?


Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

@TravisEz13
Copy link
Contributor

GitHub says readme.md has a conflict

@kwirkykat kwirkykat added needs review The pull request needs a code review. and removed waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels Dec 2, 2016
@TravisEz13
Copy link
Contributor

Reviewed 2 of 3 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@TravisEz13 TravisEz13 merged commit 8545f06 into dsccommunity:dev Dec 2, 2016
@TravisEz13 TravisEz13 removed the needs review The pull request needs a code review. label Dec 2, 2016
Amedama96 pushed a commit to Amedama96/xPSDesiredStateConfiguration that referenced this pull request Dec 3, 2016
* xPackage fixes and updates

* Replaces Out-Null with $null assignments

* Resolves README.md merge conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants