-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows Package Cab #251
Conversation
1fabf9f
to
22dc1f8
Compare
Reviewed 1 of 9 files at r1. README.md, line 38 at r1 (raw file):
Extra 'to' Comments from Reviewable |
Reviewed 8 of 9 files at r1. DSCResources/MSFT_xWindowsPackageCab/MSFT_xWindowsPackageCab.psm1, line 15 at r1 (raw file):
'Provide here to follow DSC design policy of requiring Get/Set/Test to have the same Mandatory Parameters' Examples/Sample_xWindowsPackageCab.ps1, line 3 at r1 (raw file):
'from the cab file' also, maybe split this up into 2 lines Tests/Integration/MSFT_xWindowsPackageCab.Integration.Tests.ps1, line 1 at r1 (raw file):
Use Join/Split :p Tests/Integration/MSFT_xWindowsPackageCab.Integration.Tests.ps1, line 28 at r1 (raw file):
extra newline here needs to be deleted Tests/Unit/MSFT_xWindowsPackageCab.Tests.ps1, line 1 at r1 (raw file):
Join/Split Tests/Unit/MSFT_xWindowsPackageCab.Tests.ps1, line 30 at r1 (raw file):
'...when package is not installed' Tests/Unit/MSFT_xWindowsPackageCab.Tests.ps1, line 37 at r1 (raw file):
this says 'when package is present but not installed' but the Mock is returning 'NotPresent' is this the correct description? Tests/Unit/MSFT_xWindowsPackageCab.Tests.ps1, line 76 at r1 (raw file):
split up this line Comments from Reviewable |
22dc1f8
to
4f1faae
Compare
Review status: 4 of 9 files reviewed at latest revision, 9 unresolved discussions. README.md, line 38 at r1 (raw file):
|
Reviewed 5 of 5 files at r2. Comments from Reviewable |
This is part of #160.
This is a new resource that was recently provided in-box specifically for Nano Server (though it also works on full Windows Server) in order to install downloaded packages from Windows cabinet (.cab) files.
The in-box WindowsPackageCab resource has been translated to a mof-based resource (from a class-based resource) so that it works here with WMF 4.
This resource now has 100% unit test coverage.
I have run the integration tests manually on both full Windows Server and Windows Nano Server, and all tests are passing.
Unfortunately, I cannot include the cab file I used for integration testing on GitHub, so the two integration tests that require an actual cab file will be skipped on AppVeyor for now.
If you would like to run the integration tests yourself, you will need to provide your own cab file in the BeforeAll block of the WindowsPackageCab integration tests. Also, if you do run the full integration tests, make sure they are running on a disposable VM instead of on your development machine.
We are working on locating a suitable cab file for automated testing.
@mbreakey3 Please review
This change is