Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: xWindowsOptionalFeature: Remove the Source parameter #229

Closed
kwirkykat opened this issue Sep 12, 2016 · 0 comments · Fixed by #237
Closed

BREAKING CHANGE: xWindowsOptionalFeature: Remove the Source parameter #229

kwirkykat opened this issue Sep 12, 2016 · 0 comments · Fixed by #237
Assignees
@kwirkykat
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.

Comments

@kwirkykat
Copy link
Contributor

Please do not work on this issue until WindowsOptionalFeature has been merged from in-box as part of #160

In xWindowsOptionalFeature the Source parameter is not used.
It has not been implemented, it's not mandatory, and it is not a key, so it should be removed.
@kwirkykat kwirkykat added the enhancement The issue is an enhancement request. label Sep 12, 2016
@kwirkykat kwirkykat self-assigned this Sep 13, 2016
@kwirkykat kwirkykat added the in progress The issue is being actively worked on by someone. label Sep 13, 2016
@kwirkykat kwirkykat mentioned this issue Sep 14, 2016
Merged
@kwirkykat kwirkykat added the breaking change When used on an issue, the issue has been determined to be a breaking change. label Sep 14, 2016
@kwirkykat kwirkykat changed the title xWindowsOptionalFeature: Remove the Source parameter BREAKING CHANGE: xWindowsOptionalFeature: Remove the Source parameter Sep 14, 2016
kwirkykat added a commit that referenced this issue Sep 20, 2016
@kwirkykat
Merge pull request #237 from kwirkykat/MergeWOF
77b398f 
BREAKING CHANGE: xWindowsOptionalFeature: Update to a high quality resource (Fixes #229)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwirkykat kwirkykat

Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.
Projects
None yet
Milestone
No milestone
1 participant
@kwirkykat