Skip to content

Commit

Permalink
xGroup: Refactored Principal Resolution Functions for Enhanced Virtua…
Browse files Browse the repository at this point in the history
…l Account Support (#764)

* Refactored Principal Resolution Functions for Enhanced Virtual Account
Support

- Enhanced Test-IsLocalMachine to recognize 'IIS APPPOOL' and
  'NT VIRTUAL MACHINE' as local machine scopes, improving virtual
  account type coverage.
- Updated Split-MemberName to preserve original scope, allowing local
  accounts that do not use the computer name to be resolved.
- Extended Find-Principal with a new Scope parameter, enabling searches
  additional local machine scopes.
- Augmented Find-Principal to handle a predefined list of NT account
  scopes ('NT Authority', 'NT Service', 'IIS APPPOOL',
  'NT Virtual Machine'), utilizing System.Security.Principal.NTAccount
  for SID resolution. This enhancement focuses on local virtual account
  identification.
- Implemented new integration tests for ConvertTo-Principal to verify
  local, virtual account resolution.
- Introduced Get-ScopeFromDistinguishedName to accurately parse scope
  from distinguished names, addressing issues with multiple domain
  components and escaped commas.
- Added unit tests for Get-ScopeFromDistinguishedName, ensuring
  functional correctness.
- Adjusted outside domain test to expect 'domain.com' instead of
  'domain'.

* Updating chagelog

* Fixing assertion in xDSCWebService for
mock call count.

* - Modify assertion for the number of calls to the
Test-Path mock to account for the
short-circuiting of the if conditions  on line 449
of DSC_xDSCWebService.psm1 preventing the
third condition from being evaluated.

* - Fixing issues identified during the pull request
review process
  • Loading branch information
kenny-scelfo authored Nov 11, 2023
1 parent 7703bb1 commit 1d48c47
Show file tree
Hide file tree
Showing 5 changed files with 219 additions and 106 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- xGroup
- Fixed a bug where the resource would fail if any of the group members were local, virtual accounts. - Fixes [Issue #763](https://github.com/dsccommunity/xPSDesiredStateConfiguration/issues/763)
- Fixed a bug where members with distinguished names that contained multiple domain components would only have the first domain component included in the account scope.
- Fixed a bug where members with distinguished names that contained an escaped comma would not be parsed correctly.
- xPackage
- Fixed a bug not allowing using the file hash of an installer [Issue #702](https://github.com/dsccommunity/xPSDesiredStateConfiguration/issues/702).
- xPSDesiredStateConfiguration
- Updated CI pipeline to remove Azure DevOps deprecated Windows Server 2016
image and add Windows Server 2022 - Fixes [Issue #752](https://github.com/dsccommunity/xPSDesiredStateConfiguration/issues/752).
- xDSCWebService
- Fixed a bug where the variable ```DscWebServiceDefaultAppPoolName``` is not set in the resource xDSCWebService since version 9.0.0 as a result of module refactoring.
- Fixed a bug where the variable ```DscWebServiceDefaultAppPoolName``` is not set in the resource xDSCWebService since version 9.0.0 as a result of module refactoring
### Fixed

- xPSDesiredStateConfiguration
Expand Down
Loading

0 comments on commit 1d48c47

Please sign in to comment.