SqlDatabaseObjectPermission: Fixing issue with INSERT permissions

[markaugust]

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Adding a foreach loop when checking object permissions to avoid issues with INSERT permissions

• Fixes SqlDatabaseObjectPermission: INSERT permission never shows as InDesiredState when other permissions are on the table #2006

Task list

• Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• Resource documentation updated in the resource's README.md.
• Resource parameter descriptions updated in schema.mof.
• Comment-based help updated, including parameter descriptions.
• Localization strings updated.
• Examples updated.
• Unit tests updated. See DSC Community Testing Guidelines.
• Integration tests updated (where possible). See DSC Community Testing Guidelines.
• Code changes adheres to DSC Community Style Guidelines.

---

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94%. Comparing base (a5c29fe) to head (d926778).

Additional details and impacted files

@@         Coverage Diff          @@
##           main   #2007   +/-   ##
====================================
  Coverage    94%     94%           
====================================
  Files        94      94           
  Lines      7919    7920    +1     
====================================
+ Hits       7489    7490    +1     
  Misses      430     430           

Flag	Coverage Δ
unit	94% <100%> (+<1%)	⬆️

Files	Coverage Δ
...ectPermission/DSC_SqlDatabaseObjectPermission.psm1	100% <100%> (ø)

[johlju]

Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @markaugust)

---

tests/Unit/DSC_SqlDatabaseObjectPermission.Tests.ps1 line 160 at r2 (raw file):

            }

            Mock -CommandName Get-DatabaseObject -MockWith {

This mock should be updated to mimic the types that is returned when INSERT is used. Looks like IList in the issue? Then this test should fail without the suggested change, and tests should pass with the suggested change.
Do you have time to look into a changing the mock?

[markaugust]

@johlju I'm not familiar enough with Mocks and Unit test to know exactly what needs to be done here. Looking at the code block, I made some changes to the unit test, but let me know if that's not what you were meaning.

[johlju]

I will review this PR as soon as I have time. Will look over the changes to the test you made. Good work!

[johlju]

Unit tests looks okay, it correctly fails without the proposed change. I push a change to the integration test to try to mimic the scenario in the issue.

[johlju]

Reviewed 3 of 3 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @markaugust)

[johlju]

@markaugust great work on this!

[markaugust]

Thank you @johlju . Out of curiosity, is there a timeline on when those fixes will get moved into a full release branch, rather than just in a preview branch?

[johlju]

Usually when we (community) feel there should be a new full release. I pushed a release tag now, so should release if pipeline don't fail 😊