Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Comment Based Help for New-NotImplementedException - Fixes #411 #412

Merged
merged 1 commit into from
Jul 6, 2019
Merged

Added Comment Based Help for New-NotImplementedException - Fixes #411 #412

merged 1 commit into from
Jul 6, 2019

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Jul 5, 2019

Pull Request (PR) description

This PR adds missing comment based help to New-NotImplementedException function.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing for me?


This change is Reviewable

@codecov-io
Copy link

Codecov Report

Merging #412 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #412   +/-   ##
===================================
  Coverage    95%    95%           
===================================
  Files        28     28           
  Lines      2272   2272           
===================================
  Hits       2172   2172           
  Misses      100    100

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit ad720b2 into dsccommunity:dev Jul 6, 2019
@PlagueHO PlagueHO deleted the Issue-411 branch July 6, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Common Function New-NotImplementedException Missing Comment Based Help
3 participants