Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples for xDefaultGatewayAddress - Fixes #275 #276

Merged
merged 2 commits into from
Oct 26, 2017
Merged

Fix examples for xDefaultGatewayAddress - Fixes #275 #276

merged 2 commits into from
Oct 26, 2017

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Oct 26, 2017

Pull Request (PR) description
Correct examples in xDefaultGatewayAddress

This Pull Request (PR) fixes the following issues:
Fixes #275

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Oct 26, 2017
@PlagueHO PlagueHO self-assigned this Oct 26, 2017
@PlagueHO PlagueHO requested a review from tysonjhayes October 26, 2017 07:18
@codecov-io
Copy link

codecov-io commented Oct 26, 2017

Codecov Report

Merging #276 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #276   +/-   ##
===================================
  Coverage    97%    97%           
===================================
  Files        21     21           
  Lines      1698   1698           
===================================
  Hits       1662   1662           
  Misses       36     36

@tysonjhayes
Copy link
Collaborator

:lgtm:


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@tysonjhayes tysonjhayes merged commit fdeb91c into dsccommunity:dev Oct 26, 2017
@joeyaiello joeyaiello removed the needs review The pull request needs a code review. label Oct 26, 2017
@PlagueHO PlagueHO deleted the Issue-275 branch October 27, 2017 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xDefaultGatewayAddress Example 2 AddressFamily is incorrect
4 participants