Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor IP Address Validation into Common Function #408

Closed
PlagueHO opened this issue Jun 22, 2019 · 2 comments · Fixed by #449
Closed

Refactor IP Address Validation into Common Function #408

PlagueHO opened this issue Jun 22, 2019 · 2 comments · Fixed by #449
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@PlagueHO
Copy link
Member

DefaultGatewayAddress, DnsServerAddress, IPAddress, Route all validate an IP address is valid. The code is duplicated in each of these modules. It should be refactored into the Common module.
@PlagueHO PlagueHO added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Jun 22, 2019
@valainisgt
Copy link
Contributor

I am working on this.

@VortexD99
Copy link

VortexD99 commented Apr 25, 2020 via email

@valainisgt valainisgt mentioned this issue Apr 25, 2020
Merged
9 tasks
johlju pushed a commit that referenced this issue May 2, 2020
@valainisgt
Common: Added Test-IPAddress function (#449)
d6a7d8a 
- Common
  - Added Assert-IPAddress function to reduce code duplication - Fixes Issue #408.
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Common: Added Test-IPAddress function
4 participants
@valainisgt @johlju @PlagueHO @VortexD99