-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BOM, Optin to Common Tests, Fix License Year, Add VSCode Styles - Fixes 87 #92
Conversation
@johlju - another one for you if you have a moment! Thank you so much BTW! No rush - only work on bringing the module up to standards of the others. |
Reviewed 10 of 10 files at r1. README.md, line 215 at r1 (raw file):
You got a '.' at the end here, it shouldn't be there I think. Comments from Reviewable |
Thanks @johlju - good catch. Fixed. Could you sign off for me? Thanks sir! Review status: 9 of 10 files reviewed at latest revision, 1 unresolved discussion. README.md, line 215 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. Comments from Reviewable |
Reviewed 1 of 1 files at r2. Comments from Reviewable |
I'm ignoring code coverage warning, because I've yet to work on getting code coverage to 70%. Will work on this today. |
Pull Request (PR) description
Several of the module files were using UTF8 with BOM encoding. This PR converts them to UTF8 encoding. It also opts into the common tests:
"Common Tests - Validate Module Files"
"Common Tests - Validate Script Files"
The copyright year has also been updated to 2017 in the License.md and the module manifest.
The standard GitHub templates were added and the standard VSCode style settings were included as well.
This Pull Request (PR) fixes the following issues:
Fixes #87
Fixes #88
Fixes #90
Fixes #91
Task list:
This change is