Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BOM, Optin to Common Tests, Fix License Year, Add VSCode Styles - Fixes 87 #92

Merged
merged 5 commits into from
Aug 11, 2017

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Aug 10, 2017

Pull Request (PR) description
Several of the module files were using UTF8 with BOM encoding. This PR converts them to UTF8 encoding. It also opts into the common tests:
"Common Tests - Validate Module Files"
"Common Tests - Validate Script Files"

The copyright year has also been updated to 2017 in the License.md and the module manifest.

The standard GitHub templates were added and the standard VSCode style settings were included as well.

This Pull Request (PR) fixes the following issues:
Fixes #87
Fixes #88
Fixes #90
Fixes #91

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Aug 10, 2017
@PlagueHO PlagueHO self-assigned this Aug 10, 2017
@PlagueHO
Copy link
Member Author

@johlju - another one for you if you have a moment! Thank you so much BTW! No rush - only work on bringing the module up to standards of the others.

@codecov-io
Copy link

codecov-io commented Aug 10, 2017

Codecov Report

Merging #92 into dev will not change coverage.
The diff coverage is 33%.

Impacted file tree graph

@@        Coverage Diff        @@
##           dev   #92   +/-   ##
=================================
  Coverage   68%   68%           
=================================
  Files        6     6           
  Lines      719   719           
=================================
  Hits       494   494           
  Misses     225   225

@johlju
Copy link
Member

johlju commented Aug 10, 2017

:lgtm:


Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


README.md, line 215 at r1 (raw file):

  tests.
* Replaced examples in README.MD to links to Example files.
* Added the VS Code PowerShell extension formatting settings that cause PowerShell.

You got a '.' at the end here, it shouldn't be there I think.


Comments from Reviewable

@PlagueHO
Copy link
Member Author

Thanks @johlju - good catch. Fixed. Could you sign off for me? Thanks sir!


Review status: 9 of 10 files reviewed at latest revision, 1 unresolved discussion.


README.md, line 215 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

You got a '.' at the end here, it shouldn't be there I think.

Done.


Comments from Reviewable

@johlju
Copy link
Member

johlju commented Aug 11, 2017

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@PlagueHO
Copy link
Member Author

I'm ignoring code coverage warning, because I've yet to work on getting code coverage to 70%. Will work on this today.

@PlagueHO PlagueHO merged commit a7954f5 into dsccommunity:dev Aug 11, 2017
@PlagueHO PlagueHO deleted the Issue-87-and-88 branch August 11, 2017 20:36
@joeyaiello joeyaiello removed the needs review The pull request needs a code review. label Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants